Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home] Fixes Kibana app description order on home page and updates Canvas copy #80057

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 8, 2020

Summary

This fixes the app description order on the Kibana solution card on the home page, and also updates the app description for Canvas.

Screen Shot 2020-10-08 at 12 32 22 PM

Screen Shot 2020-10-08 at 12 32 27 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0 labels Oct 8, 2020
@cqliu1 cqliu1 requested a review from KOTungseth October 8, 2020 19:37
@cqliu1 cqliu1 requested a review from a team as a code owner October 8, 2020 19:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@@ -109,7 +109,7 @@ export class KibanaOverviewPlugin
defaultMessage: 'Search and find insights.',
}),
i18n.translate('kibanaOverview.kibana.appDescription3', {
defaultMessage: 'Design pixel-perfect reports.',
defaultMessage: 'Design pixel-perfect presentation.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be plural like the other description?

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, thank you!

@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 12, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 21, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 26, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
home 394.6KB 394.6KB +18.0B

page load bundle size

id before after diff
canvas 1014.7KB 1014.7KB +6.0B
kibanaOverview 40.3KB 40.3KB +6.0B
total +12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 26cad3c into elastic:master Oct 26, 2020
@cqliu1 cqliu1 deleted the canvas/copy-updates branch October 26, 2020 22:39
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 26, 2020
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 26, 2020
cqliu1 added a commit that referenced this pull request Oct 27, 2020
…nvas copy (#80057) (#81692)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
cqliu1 added a commit that referenced this pull request Oct 27, 2020
…nvas copy (#80057) (#81691)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 27, 2020
* master: (37 commits)
  [ILM] Migrate Warm phase to Form Lib (elastic#81323)
  [Security Solutions][Detection Engine] Fixes critical bug with error reporting that was doing a throw (elastic#81549)
  [Detection Rules] Add 7.10 rules (elastic#81676)
  [kbn/optimizer] ignore missing metrics when updating limits with --focus (elastic#81696)
  [SECURITY SOLUTIONS] Bugs overview page + investigate eql in timeline (elastic#81550)
  [Maps] fix unable to edit cluster vector styles styled by count when switching to super fine grid resolution (elastic#81525)
  Fixed migration issue for case specific actions, by extending email action migrator checks (elastic#81673)
  [CI] Preparation for APM tracking on CI (elastic#80399)
  [Home] Fixes Kibana app description order on home page and updates Canvas copy (elastic#80057)
  Make sure `to` is 'now' and not the same as `from` (elastic#81524)
  Nitpicking the 8.0 Breaking Change issue template (elastic#81678)
  [SECURITY_SOLUTION] Fix text on onboarding screen (elastic#81672)
  [data.search] Skip async search tests in build candidates and production builds (elastic#81547)
  Fix previousStartedAt by not changing when execution fails (elastic#81388)
  [Monitoring] Fix a couple of issues with the cpu usage alert (elastic#80737)
  Telemetry collection xpack to ts project references (elastic#81269)
  Elasticsearch: don't use url authentication for new client (elastic#81564)
  [App Search] Credentials: implement working flyout form (elastic#81541)
  Properly encode links to edit user page (elastic#81562)
  [Alerting UI] Don't wait for health check before showing Create Alert flyout (elastic#80996)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants