Skip to content

Commit

Permalink
[Home] Fixes Kibana app description order on home page and updates Ca…
Browse files Browse the repository at this point in the history
…nvas copy (#80057) (#81692)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
cqliu1 and kibanamachine authored Oct 27, 2020
1 parent 1998274 commit d1e6521
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import { SolutionPanel } from './solution_panel';
import { FeatureCatalogueEntry, FeatureCatalogueSolution } from '../../../';

const sortByOrder = (
{ order: orderA = 0 }: FeatureCatalogueSolution,
{ order: orderB = 0 }: FeatureCatalogueSolution
{ order: orderA = 0 }: FeatureCatalogueSolution | FeatureCatalogueEntry,
{ order: orderB = 0 }: FeatureCatalogueSolution | FeatureCatalogueEntry
) => orderA - orderB;

interface Props {
Expand All @@ -38,7 +38,9 @@ interface Props {
export const SolutionsSection: FC<Props> = ({ addBasePath, solutions, directories }) => {
// Separate Kibana from other solutions
const kibana = solutions.find(({ id }) => id === 'kibana');
const kibanaApps = directories.filter(({ solutionId }) => solutionId === 'kibana');
const kibanaApps = directories
.filter(({ solutionId }) => solutionId === 'kibana')
.sort(sortByOrder);
solutions = solutions.sort(sortByOrder).filter(({ id }) => id !== 'kibana');

return (
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/kibana_overview/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export class KibanaOverviewPlugin
defaultMessage: 'Search and find insights.',
}),
i18n.translate('kibanaOverview.kibana.appDescription3', {
defaultMessage: 'Design pixel-perfect reports.',
defaultMessage: 'Design pixel-perfect presentations.',
}),
i18n.translate('kibanaOverview.kibana.appDescription4', {
defaultMessage: 'Plot geographic data.',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/public/feature_catalogue_entry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const featureCatalogueEntry = {
id: 'canvas',
title: 'Canvas',
subtitle: i18n.translate('xpack.canvas.featureCatalogue.canvasSubtitle', {
defaultMessage: 'Design pixel-perfect reports.',
defaultMessage: 'Design pixel-perfect presentations.',
}),
description: i18n.translate('xpack.canvas.appDescription', {
defaultMessage: 'Showcase your data in a pixel-perfect way.',
Expand Down

0 comments on commit d1e6521

Please sign in to comment.