-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Line Visualization improper scaling can result in gaps #80010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
v7.11.0
v8.0.0
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Feature:Aggregations
Aggregation infrastructure (AggConfig, esaggs, ...)
labels
Oct 8, 2020
💔 Build Failed
Failed CI StepsTest FailuresChrome UI Functional Tests.test/functional/apps/visualize/_area_chart·js.visualize app area charts date histogram interval expanded accordion should update scaled label text after custom interval is set and time range is changedStandard Out
Stack Trace
Chrome UI Functional Tests.test/functional/apps/visualize/_area_chart·js.visualize app area charts date histogram interval expanded accordion should update scaled label text after custom interval is set and time range is changedStandard Out
Stack Trace
Metrics [docs]page load bundle size
To update your PR or re-run it, just comment with: |
[WIP] found some regression |
alexwizp
changed the title
Line Visualization improper scaling can result in gaps
[WIP] Line Visualization improper scaling can result in gaps
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Aggregations
Aggregation infrastructure (AggConfig, esaggs, ...)
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79663
Summary
During the euificate of the
visualization editor
, we forgot aboutuseNormalizedEsInterval
parameter. As a result,custom intervals
is not handled properly. It seems to me that we can remove this parameter completely and set the value based onintervalOptions
objectChecklist
Delete any items that are not applicable to this PR.
For maintainers