-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build all ts refs in a single kbn:bootstrap #79438
Merged
mshustov
merged 1 commit into
elastic:master
from
mshustov:remove-concurrent-build-ts-refs
Oct 6, 2020
Merged
build all ts refs in a single kbn:bootstrap #79438
mshustov
merged 1 commit into
elastic:master
from
mshustov:remove-concurrent-build-ts-refs
Oct 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
labels
Oct 5, 2020
Pinging @elastic/kibana-platform (Team:Platform) |
spalger
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 6, 2020
* master: (85 commits) Refactor attribute service (elastic#78414) [APM] Add default message to alerts. (elastic#78930) [Discover] Modify columns and sort when switching index pattern (elastic#74336) Document ts project references setup (elastic#78586) build all ts refs in single kbn:bootstrap (elastic#79438) [TSVB] Allow string fields on value count aggregation (elastic#79267) [SECURITY SOLUTION] Investigate EQL signal in timeline (elastic#79049) [Fleet] Add loading spinner to page headers (elastic#79568) [Security Solution][Resolver] Resolver query panel load more (elastic#79160) Add type row to monitor detail page. (elastic#79556) Remove license refresh from setup (elastic#79518) [docker] add reporting fonts (elastic#74806) [SECURITY_SOLUTION][ENDPOINT] Add info about trusted apps to the page subtitle + create flyout (elastic#79558) Trim Hash value before validating it (elastic#79545) Warn users when security is not configured (elastic#78545) update copy styling (elastic#79313) Update dependency @elastic/charts to v23.1.1 (elastic#78459) Introduce geo-threshold alerts (elastic#76285) elastic#76920 Show base breadcrumb when there is an error booting the app (elastic#79571) remove react-intl from kibana and keep it inside only i18n package (elastic#78956) ...
mshustov
added a commit
that referenced
this pull request
Oct 6, 2020
rudolf
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #78440 had been merged, Kibana has experienced a couple of strange CI failures:
https://kibana-ci.elastic.co/job/elastic+kibana+baseline-capture/5283/execution/node/155/log/
https://kibana-ci.elastic.co/job/elastic+kibana+baseline-capture/5307/execution/node/155/log/
https://kibana-ci.elastic.co/job/elastic+kibana+master/8633/execution/node/96/log
The failure has sporadic character, and I didn't manage to reproduce it locally. It makes me think the problem has to do something with the concurrency of TS builds. This PR reverts parallel build of oss & x-pack TS projects introduced in #78440