remove react-intl from kibana and keep it inside only i18n package #78956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
timroes
approved these changes
Oct 1, 2020
patrykkopycinski
approved these changes
Oct 1, 2020
cee-chen
approved these changes
Oct 1, 2020
Comment on lines
+12
to
+19
| // Use fake component to extract `intl` property to use in tests. | ||
| const { intl } = (mount( | ||
| <I18nProvider> | ||
| <br /> | ||
| </I18nProvider> | ||
| ).find('IntlProvider') as ReactWrapper<{}, {}, __IntlProvider>) | ||
| .instance() | ||
| .getChildContext(); |
There was a problem hiding this comment.
This is super creative, thank you for figuring it out for us! 🙏
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/ui-shared-deps asset size
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
Bamieh
added a commit
that referenced
this pull request
Oct 6, 2020
…age (#78956) (#79589) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 6, 2020
* master: (85 commits) Refactor attribute service (elastic#78414) [APM] Add default message to alerts. (elastic#78930) [Discover] Modify columns and sort when switching index pattern (elastic#74336) Document ts project references setup (elastic#78586) build all ts refs in single kbn:bootstrap (elastic#79438) [TSVB] Allow string fields on value count aggregation (elastic#79267) [SECURITY SOLUTION] Investigate EQL signal in timeline (elastic#79049) [Fleet] Add loading spinner to page headers (elastic#79568) [Security Solution][Resolver] Resolver query panel load more (elastic#79160) Add type row to monitor detail page. (elastic#79556) Remove license refresh from setup (elastic#79518) [docker] add reporting fonts (elastic#74806) [SECURITY_SOLUTION][ENDPOINT] Add info about trusted apps to the page subtitle + create flyout (elastic#79558) Trim Hash value before validating it (elastic#79545) Warn users when security is not configured (elastic#78545) update copy styling (elastic#79313) Update dependency @elastic/charts to v23.1.1 (elastic#78459) Introduce geo-threshold alerts (elastic#76285) elastic#76920 Show base breadcrumb when there is an error booting the app (elastic#79571) remove react-intl from kibana and keep it inside only i18n package (elastic#78956) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove react-intl from kibana and keep it inside only i18n package
This helps upgrade the packages in the future, and reduce the number of shared deps in kibana.