Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v29.0.0 #77802

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Upgrade EUI to v29.0.0 #77802

merged 4 commits into from
Sep 18, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 17, 2020 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

  • Lots of good updates for EuiSelectableTemplateSitewide
  • Some nice bugfixes
  • Confirmed no ill effects from the breaking change
  • Trying to keep these update PRs smaller 😅

29.0.0

  • Added .browserslistrc for global browser support reference (#4022)
  • Added ability to specify color of EuiHeaderLink (#4008)
  • Added boolean type to the notification prop of EuiHeaderSectionItemButton to show a simple dot (#4008)
  • Added popoverButton and popoverButtonBreakpoints props to EuiSelectableTemplateSitewide for responsive capabilities (#4008)
  • Added isWithinMaxBreakpoint service (#4008)
  • Added horizontal line separator to EuiContextMenu (#4018)

Bug fixes

  • Fixed EuiSuperDatePicker got stuck in update mode if the value is not changed (#4025)
  • Fixed ref not being handled properly in EuiValidatableControl when used with react-hook-form (#4001)
  • Fixed EuiNotificationBadge color prop type (#4008)
  • Fixed z-index of EuiBottomBar to stay under header (#4008)
  • Fixed regression of EuiSelectable not abiding by the showIcons prop (#4008)
  • Fixed contrast of search input of EuiSelectableTemplateSitewide in dark header (#4008)
  • Fixed EuiImage unable to deactivate the full screen mode using the close icon (#4033)
  • Allowed onClick prop when href prop is provided in EuiBadge (#4035)

Breaking changes

  • Changed EuiHideFor and EuiShowFor from using media queries to hide content to not rendering the content. Children are now required and display has been removed (#4008)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 17, 2020
@thompsongl thompsongl marked this pull request as ready for review September 17, 2020 20:17
@thompsongl thompsongl requested review from a team as code owners September 17, 2020 20:17
pgayvallet
pgayvallet approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streamich streamich mentioned this pull request Sep 18, 2020
Merged
2 tasks
@ryankeairns ryankeairns mentioned this pull request Sep 18, 2020
Closed
@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

distributable file count

id value diff baseline
default 45921 +1 45920
oss 26658 +1 26657
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 07891be into elastic:master Sep 18, 2020
thompsongl added a commit to thompsongl/kibana that referenced this pull request Sep 18, 2020
@thompsongl @elasticmachine
Upgrade EUI to v29.0.0 (elastic#77802)
8299071 
* eui to 29.0.0

* src snapshot updates

* x-pack snapshot updates

Co-authored-by: Elastic Machine <[email protected]>
@thompsongl thompsongl mentioned this pull request Sep 18, 2020
Merged
thompsongl added a commit that referenced this pull request Sep 18, 2020
@thompsongl @elasticmachine
Upgrade EUI to v29.0.0 (#77802) (#77943)
48217e3 
* eui to 29.0.0

* src snapshot updates

* x-pack snapshot updates

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@snide snide mentioned this pull request Sep 18, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thompsongl @kibanamachine @pgayvallet @jbudz @elasticmachine