-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed EuiImage deactivate fullscreen event propagation #4033
Fixed EuiImage deactivate fullscreen event propagation #4033
Conversation
- Moved nested button out to prevent event propagation that trigger the activation of full screen mode
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4033/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good!
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4033/ |
Summary
Fixed #4032: Moved nested button out to prevent event propagation that trigger the activation of full screen mode
Checklist
- [ ] Added documentation- [ ] Checked for breaking changes and labeled appropriately