[4.x] callWithRequest: do not pass content length header #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport 5959 to 4.x
While there are still hardcoded defaults, this change allows people to specify custom credentials via environment variables for each shield role in our tests. Fixes elastic#5967
8 new discover tests, _field_data
…Firefox version changes message.
Discover shared link tests 4x merge from elastic#6010
…f on the editableVis.params. Fixes elastic#5942
New tests for expand/collapse discover tab legend and sidebar. backport elastic#6032
Snake case v4.x backport elastic#6038
[backport] PR elastic#7009 to 4.x
--------- **Commit 1:** [build] Cleanup dirs on uninstall * Original sha: 29e26de * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T22:05:28Z
[backport] PR elastic#7422 to 4.x
Switch from Firefox to Chrome
--------- **Commit 1:** [build] Add data directory that plugins can write to. Closes elastic#7157 * Original sha: 5b19534 * Authored by Jonathan Budzenski <[email protected]> on 2016-06-14T16:50:40Z **Commit 2:** [config] Add path.conf, path.data * Original sha: 16e8975 * Authored by Jonathan Budzenski <[email protected]> on 2016-06-16T16:17:51Z
[backport] PR elastic#7457 to 4.x
[4.x] Bump node to 4.4.7 and npm to 2.15.8
--------- **Commit 1:** [build] Add package log path * Original sha: f781c80 * Authored by Jonathan Budzenski <[email protected]> on 2016-06-30T16:06:10Z
[backport] PR elastic#7593 to 4.x
…ssthru-all-headers [4.x] Make callWithRequest pass through all headers
ycombinator
deleted the
call-with-request/do-not-pass-content-length-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution implemented in #6896 passes through all headers to Elasticsearch, including the
Content-Lengthheader. This is not correct as request being sent to Elasticsearch from the Kibana server is not the same as the request sent from the browser to Kibana, so their body lengths may differ.