Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url shortener] Use kibana.index config value, and fix silent error #7009

Merged
merged 1 commit into from
Apr 21, 2016
Merged

[url shortener] Use kibana.index config value, and fix silent error #7009

merged 1 commit into from
Apr 21, 2016

Conversation

BigFunger
Copy link
Contributor

Fixes #7006

  • The url shortener now looks up the kibana index value from config
  • Fixed it so that the endpoint doesn't fail silently if there is a problem.

@w33ble
Copy link
Contributor

w33ble commented Apr 21, 2016

Invalid indexes result in a 500 error message, and writing to a non-standard index works as expected.

LGTM!

@w33ble w33ble merged commit f379074 into elastic:master Apr 21, 2016
elastic-jasper added a commit that referenced this pull request Apr 21, 2016
@elastic-jasper
Backport PR #7009
23889d0 
---------

**Commit 1:**
[url shortener] Use kibana.index config value, and fix silent error

* Original sha: 313bfc8
* Authored by Jim Unger <[email protected]> on 2016-04-21T21:22:58Z
elastic-jasper added a commit that referenced this pull request Apr 21, 2016
@elastic-jasper
Backport PR #7009
635d478 
---------

**Commit 1:**
[url shortener] Use kibana.index config value, and fix silent error

* Original sha: 313bfc8
* Authored by Jim Unger <[email protected]> on 2016-04-21T21:22:58Z
This was referenced Apr 21, 2016
Merged
Merged
w33ble added a commit that referenced this pull request Apr 22, 2016
@w33ble
Merge pull request #7018 from elastic/jasper/backport/7009/4.4
23822e2 
[backport] PR #7009 to 4.4
w33ble added a commit that referenced this pull request Apr 22, 2016
@w33ble
Merge pull request #7017 from elastic/jasper/backport/7009/4.5
fdb10e4 
[backport] PR #7009 to 4.5
@Bargs Bargs mentioned this pull request Apr 22, 2016
Closed
@epixa epixa added v4.5.2 and removed v4.5.1 labels May 14, 2016
@epixa epixa added the v4.6.0 label Jun 17, 2016
elastic-jasper added a commit that referenced this pull request Jun 17, 2016
@elastic-jasper
Backport PR #7009
ee39b00 
---------

**Commit 1:**
[url shortener] Use kibana.index config value, and fix silent error

* Original sha: 313bfc8
* Authored by Jim Unger <[email protected]> on 2016-04-21T21:22:58Z
@elastic-jasper elastic-jasper mentioned this pull request Jun 17, 2016
Merged
BigFunger added a commit that referenced this pull request Jun 17, 2016
@BigFunger
Merge pull request #7497 from elastic/jasper/backport/7009/4.x
0d7c0df 
[backport] PR #7009 to 4.x
@epixa epixa added v4.5.4 and removed v4.5.2 labels Jul 20, 2016
@epixa epixa removed the v4.4.3 label Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@w33ble w33ble

Labels
review v4.5.4 v4.6.0 v5.0.0-alpha2 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigFunger @w33ble @epixa