Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Uptime] Fix alerting false positives (#75577) #76300

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

justinkambic
Copy link
Contributor

Backports the following commits to 7.x:

* Add test and modify code to account for complex filter input.

* Avoid unnecessary nesting.

* Simplify filtering code.

* Use `must` instead of `should`.

* Fix types.

* Refresh snapshots.

* Use `filter` instead of `must`.

* Refactor to improve readability.

* Resolve filtering issue for availability query.

* Add test covering filter fix.

* Removed unused var.

Co-authored-by: Elastic Machine <[email protected]>
@justinkambic justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 labels Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic self-assigned this Sep 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic merged commit 16723d1 into elastic:7.x Sep 2, 2020
@justinkambic justinkambic deleted the backport/7.x/pr-75577 branch September 2, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants