[Uptime] Fix alerting false positives #75577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
force-pushed
the
uptime_fix-monitor-status-alert-filters
branch
from
ef45eeb to
61e9c94
Compare
shahzad31
reviewed
Aug 26, 2020
andrewvc
approved these changes
Aug 26, 2020
|
@elasticmachine merge upstream |
…justinkambic/kibana into uptime_fix-monitor-status-alert-filters
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Aug 31, 2020
* Add test and modify code to account for complex filter input. * Avoid unnecessary nesting. * Simplify filtering code. * Use `must` instead of `should`. * Fix types. * Refresh snapshots. * Use `filter` instead of `must`. * Refactor to improve readability. * Resolve filtering issue for availability query. * Add test covering filter fix. * Removed unused var. Co-authored-by: Elastic Machine <[email protected]>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Aug 31, 2020
* Add test and modify code to account for complex filter input. * Avoid unnecessary nesting. * Simplify filtering code. * Use `must` instead of `should`. * Fix types. * Refresh snapshots. * Use `filter` instead of `must`. * Refactor to improve readability. * Resolve filtering issue for availability query. * Add test covering filter fix. * Removed unused var. Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # x-pack/plugins/uptime/server/lib/requests/get_monitor_availability.ts # x-pack/plugins/uptime/server/lib/requests/get_monitor_status.ts
justinkambic
added a commit
that referenced
this pull request
Sep 2, 2020
* [Uptime] Fix alerting false positives (#75577) * Add test and modify code to account for complex filter input. * Avoid unnecessary nesting. * Simplify filtering code. * Use `must` instead of `should`. * Fix types. * Refresh snapshots. * Use `filter` instead of `must`. * Refactor to improve readability. * Resolve filtering issue for availability query. * Add test covering filter fix. * Removed unused var. Co-authored-by: Elastic Machine <[email protected]> * Update broken snapshots. Co-authored-by: Elastic Machine <[email protected]>
|
Backported to: |
justinkambic
added a commit
that referenced
this pull request
Sep 2, 2020
* [Uptime] Fix alerting false positives (#75577) * Add test and modify code to account for complex filter input. * Avoid unnecessary nesting. * Simplify filtering code. * Use `must` instead of `should`. * Fix types. * Refresh snapshots. * Use `filter` instead of `must`. * Refactor to improve readability. * Resolve filtering issue for availability query. * Add test covering filter fix. * Removed unused var. Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # x-pack/plugins/uptime/server/lib/requests/get_monitor_availability.ts # x-pack/plugins/uptime/server/lib/requests/get_monitor_status.ts * Resolve type difference from master. * Refresh test snapshot. * Refresh snapshots. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74069.
There are circumstances where complex filter logic causes
query.bool.filterclauses to be rendered for ES queries. In these cases, the user-providedfilteris overwriting filters that we use. It then causes alerts to trigger for monitors that areup.I've added test cases to account for arrays and objects in this field. The coded that causes these tests to pass does not break any of the existing tests.
EDIT: while this error was discovered in the Monitor Status alert, it will also happen for the Availability query, which is composed in a very similar way. Since it's a small change to fix it, and it will be simpler to track for backporting, we will modify that code in the same patch.
Checklist
Delete any items that are not applicable to this PR.
For maintainers