[RUM Dashboard] Rum usability improvement #76024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
smith
requested changes
Aug 27, 2020
| { | ||
| name: 'Browser', | ||
| name: '- No breakdown -', |
There was a problem hiding this comment.
All of these name properties should have i18n translations.
| ); | ||
|
|
||
| const onBreakdownChange = (values: BreakdownItem[]) => { | ||
| setBreakdowns(values); | ||
| const onBreakdownChange = (value: BreakdownItem | null) => { |
There was a problem hiding this comment.
Do you need to define this function? Couldn't you just pass onBreakdownChange={setBreakdown} into the BreakdownFilter?
| breakdown: { | ||
| terms: { | ||
| field: breakdownItem.fieldName, | ||
| size: 9, |
There was a problem hiding this comment.
This was mentioned in the issue that we need to show top 9 by volume #69712
| { | ||
| name: 'Browser', | ||
| name: '- No breakdown -', |
There was a problem hiding this comment.
I don't think the - adds anything. No breakdown (with i18n) would be fine.
x-pack/plugins/apm/public/components/app/RumDashboard/Breakdowns/BreakdownFilter.tsx
Show resolved
Hide resolved
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
smith
approved these changes
Sep 3, 2020
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 4, 2020
Co-authored-by: Elastic Machine <[email protected]>
shahzad31
added a commit
that referenced
this pull request
Sep 4, 2020
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74835
Used a select component for breakdown selector