PR feedback

elastic · Sep 1, 2020 · ac5f84c · ac5f84c
1 parent 92482a5
commit ac5f84c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/x-pack/plugins/apm/public/components/app/RumDashboard/Breakdowns/BreakdownFilter.tsx b/x-pack/plugins/apm/public/components/app/RumDashboard/Breakdowns/BreakdownFilter.tsx
@@ -6,6 +6,7 @@
 
 import React from 'react';
 import { EuiSuperSelect } from '@elastic/eui';
+import { i18n } from '@kbn/i18n';
 import {
   CLIENT_GEO_COUNTRY_ISO_CODE,
   USER_AGENT_DEVICE,
@@ -27,27 +28,37 @@ export function BreakdownFilter({
 
   const items: BreakdownItem[] = [
     {
-      name: '- No breakdown -',
+      name: i18n.translate('xpack.apm.csm.breakDownFilter.noBreakdown', {
+        defaultMessage: 'No breakdown',
+      }),
       fieldName: NO_BREAKDOWN,
       type: 'category',
     },
     {
-      name: 'Browser',
+      name: i18n.translate('xpack.apm.csm.breakdownFilter.browser', {
+        defaultMessage: 'Browser',
+      }),
       fieldName: USER_AGENT_NAME,
       type: 'category',
     },
     {
-      name: 'OS',
+      name: i18n.translate('xpack.apm.csm.breakdownFilter.os', {
+        defaultMessage: 'OS',
+      }),
       fieldName: USER_AGENT_OS,
       type: 'category',
     },
     {
-      name: 'Device',
+      name: i18n.translate('xpack.apm.csm.breakdownFilter.device', {
+        defaultMessage: 'Device',
+      }),
       fieldName: USER_AGENT_DEVICE,
       type: 'category',
     },
     {
-      name: 'Location',
+      name: i18n.translate('xpack.apm.csm.breakdownFilter.location', {
+        defaultMessage: 'Location',
+      }),
       fieldName: CLIENT_GEO_COUNTRY_ISO_CODE,
       type: 'category',
     },

diff --git a/x-pack/plugins/apm/public/components/app/RumDashboard/PageViewsTrend/index.tsx b/x-pack/plugins/apm/public/components/app/RumDashboard/PageViewsTrend/index.tsx
@@ -44,10 +44,6 @@ export function PageViewsTrend() {
     [end, start, serviceName, uiFilters, breakdown]
   );
 
-  const onBreakdownChange = (value: BreakdownItem | null) => {
-    setBreakdown(value);
-  };
-
   return (
     <div>
       <EuiFlexGroup responsive={false}>
@@ -59,7 +55,7 @@ export function PageViewsTrend() {
         <EuiFlexItem grow={false} style={{ width: 170 }}>
           <BreakdownFilter
             selectedBreakdown={breakdown}
-            onBreakdownChange={onBreakdownChange}
+            onBreakdownChange={setBreakdown}
           />
         </EuiFlexItem>
       </EuiFlexGroup>