Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Horizontal Bar Percentiles Overlapping #75315

Merged
merged 4 commits into from
Aug 19, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 18, 2020

Closes: #74986

Summary

In 7.9, using the percentiles aggregation on a horizontal bar chart will result in all the percentiles bars being overlapped into the top bar.

Steps to reproduce:

  • Create a horizontal bar graph
  • Change the y axis aggregation to percentiles and set it up
  • Only one bar shows up

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp requested a review from ThomThomson August 18, 2020 16:30
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome 84, and this seems to fix the overlapping issue in both scenarios that I found it in.

Code changes LGTM!

@alexwizp alexwizp requested a review from nickofthyme August 18, 2020 19:28
@alexwizp alexwizp self-assigned this Aug 18, 2020
@alexwizp alexwizp added v7.10.0 v8.0.0 Feature:Vislib Vislib chart implementation release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 18, 2020
@alexwizp alexwizp marked this pull request as ready for review August 18, 2020 19:30
@alexwizp alexwizp requested a review from a team August 18, 2020 19:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. We had a similar issue in elastic charts recently and fixed it in a similar way.

Verified issues are resolved on Chrome (shown below) and Firefox.

Case 1

image

Case 2

image

Also verified the vertical bar chart type is unaffected.

image

image

@LeeDr
Copy link

LeeDr commented Aug 18, 2020

Can we add automated tests for this PR? We don't have anything that covers some of these visualizations options. Would be great if it doesn't have to be a UI Functional test.

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
visTypeVislib 1.3MB +102.0B 1.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 88802cb into elastic:master Aug 19, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 19, 2020
* [Visualize] Horizontal Bar Percentiles Overlapping

Closes: elastic#74986

* add tests

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
* master: (30 commits)
  [code coverage] always download node before team assignment (elastic#75424)
  [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302)
  [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555)
  skip flaky suite (elastic#75440)
  skip flaky suite (elastic#75386)
  [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172)
  [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138)
  MOAR RAM (elastic#75423)
  [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315)
  [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499)
  [ML] Inference models management (elastic#74978)
  [Monitoring] Migrate karma tests (elastic#75301)
  [Index template] Add filters to simulate preview (elastic#74497)
  Bump and consolidate dependencies (elastic#75360)
  [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364)
  Update Node.js to version 10.22.0 (elastic#75254)
  [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953)
  [Discover] Fix histogram cloud tests (elastic#75268)
  Uiactions to navigate to visualize or maps (elastic#74121)
  Use prefix search invis editor field/agg combo box (elastic#75290)
  ...
alexwizp added a commit that referenced this pull request Aug 19, 2020
* [Visualize] Horizontal Bar Percentiles Overlapping

Closes: #74986

* add tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vislib Vislib chart implementation release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visualize] Horizontal Bar Percentiles Overlapping
6 participants