-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Migrate karma tests #75301
Merged
chrisronline
merged 3 commits into
elastic:master
from
chrisronline:monitoring/move_karma_tests
Aug 19, 2020
Merged
[Monitoring] Migrate karma tests #75301
chrisronline
merged 3 commits into
elastic:master
from
chrisronline:monitoring/move_karma_tests
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
Stack Monitoring team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
labels
Aug 18, 2020
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
changed the title
Monitoring/move karma tests
[Monitoring] Migrate karma tests
Aug 18, 2020
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 Thank you for doing this!
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 19, 2020
* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...
chrisronline
added a commit
that referenced
this pull request
Aug 19, 2020
Backport 7.x: f7538f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Monitoring
Stack Monitoring team
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #71002
This PR converts legacy mocha tests to using jest. Unfortunately, not all were easily converted and a few were deleted as a result. We will need to revisit these areas in the future, but these are area in need of refactoring so I don't think much will be lost as a result.