[Lens] Use index pattern service instead saved object client #74654

mbondyra · 2020-08-10T13:29:53Z

Summary

Uses indexPatternsService provided by the data plugin to fetch index patterns instead of saved object client.
Fixes #73306
Uses displayName field property as labels instead of raw field.name.

Field displayName changes

Filtering the fields in field list should (?) be possible by field.name or field.displayName:

All the places where displayName replaces field.name:

To test it, you can add this snippet to 58. line of x-pack/plugins/lens/public/indexpattern_datasource/loader.ts:

        .map((field, i) => ({
          ...field,
          aggregatable: field.aggregatable,
          name: field.name,
          searchable: field.searchable,
          type: field.type,
          displayName: 'customName' + i,
        }));

Checklist

Unit or functional tests were updated or added to match the most common scenarios
displayName instead of raw field-name ([Lens] Use index pattern field property displayName #73021)

elasticmachine · 2020-08-14T10:33:01Z

Pinging @elastic/kibana-app (Team:KibanaApp)

mbondyra · 2020-08-17T07:04:21Z

@elasticmachine merge upstream

flash1293

I tested this in Chrome and it works great with regular index patterns, but I can't use it with rollups at all. I know there are some problems in master as well, but it seems like on this PR the fields are not shown (not sure why)

master:

this PR:

It's probably related to the IndexPatternField instance which has some methods along with the regular JSON properties. Maybe we can get around it by not spreading the field in here https://github.com/elastic/kibana/pull/74654/files#diff-2edf5b6f299eb91ac9ef5fd386eef219R72 but specifically copying over the values we actually use. Not sure though, maybe there's a big reason to use the actual IndexPatternField stuff I'm missing.

Also, I know this wasn't introduced by this PR, but the IndexPattern objects we use in Lens aren't actually IndexPatterns. It's basically this imprecise cast: https://github.com/elastic/kibana/pull/74654/files#diff-2edf5b6f299eb91ac9ef5fd386eef219R80 If it's a lot of work, please omit, but if it's easy to add, we could introduce our own type here which is actually correct (maybe just by letting type inference do it's job and using the return value of the loader).

mbondyra · 2020-08-18T11:20:57Z

@flash1293 thanks for checking - I tested the rollup indices before marking this PR as ready, but I apparently had a snippet added in my code for testing displayName and it had hidden the bug. Sorry about it!
My last commit does the typing a bit better - let me know what you think about it :)

flash1293

Tested in Chrome and Firefox and works fine for me - dotted field names are used correctly.

Search in the data panel works fine for both ways of writing the field name which is very helpful I think - in the field dropdown in the dimension popover however on the display name is considered. We can't change this for now because EUI is controlling the matcher (elastic/eui#2199). However I think the behavior is fine for now.

Added a typing nit, but this looks good to me overall

flash1293 · 2020-08-18T12:18:29Z

x-pack/plugins/lens/public/indexpattern_datasource/loader.ts

+  const indexPatterns = await Promise.all(missingIds.map((id) => indexPatternsService.get(id)));
+  const indexPatternsObject = indexPatterns.reduce(
+    (acc, indexPattern) => {
+      const newFields = (indexPattern.fields as IndexPatternField[])


This cast is not precise and can be omitted

flash1293 · 2020-08-18T12:19:30Z

x-pack/plugins/lens/public/indexpattern_datasource/loader.ts

+            aggregatable: field.aggregatable,
+            scripted: field.scripted,
+            searchable: field.searchable,
+            aggregationRestrictions: field.aggregationRestrictions,


If you remove the case from above, this line will error because the field of an IndexPattern instance doesn't have aggregationRestrictions. You can simply set this to an empty object, because to logic below will map the restrictions into the fields.

…exPatternFromIPService # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx

mbondyra · 2020-08-20T17:31:30Z

@elasticmachine merge upstream

mbondyra · 2020-08-21T07:43:43Z

@elasticmachine merge upstream

kertal

Just tested combined with #70039, LGTM

kibanamachine · 2020-08-21T09:32:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b4ef09f

Build metrics

page load bundle size

id	value	diff	baseline
lens	853.7KB	-48.0B	853.7KB

History

💚 Build #68987 succeeded 9085848
💚 Build #68802 succeeded ff6f69f
💚 Build #68702 succeeded f01ce2d
💔 Build #68699 failed fcd423f
💚 Build #68338 succeeded 8be86a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#74654)

…#75631)

* master: (71 commits) [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772) Skip failing lens test Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074) Fix returned payload by "search" usage collector (elastic#75340) [Security Solution] Fix missing key error (elastic#75576) Upgrade EUI to v27.4.1 (elastic#75240) Update datasets UI copy to data streams (elastic#75618) [Lens] Register saved object references (elastic#74523) [DOCS] Update links to Beats documentation (elastic#70380) [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616) [Usage Collection Schemas] Remove Legacy entries (elastic#75652) [Dashboard First] Lens Originating App Breadcrumb (elastic#75470) Improve login UI error message. (elastic#75642) [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579) [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163) Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536) [Console] Get ES Config from core (elastic#75406) [Uptime] Add delay in telemetry test (elastic#75162) [Lens] Use index pattern service instead saved object client (elastic#74654) Embeddable input (elastic#73033) ...

…#74654)

mbondyra added Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 labels Aug 10, 2020

mbondyra added 4 commits August 13, 2020 13:58

using indexPatternService

e244116

types

e9d2ee1

fix removed docField

0f6d445

displayName implemented

78e42e9

mbondyra force-pushed the lens/indexPatternFromIPService branch from 18dc6b6 to 78e42e9 Compare August 13, 2020 11:58

mbondyra added 2 commits August 13, 2020 19:04

tests

b3f0c65

id

66027c5

elastic deleted a comment from kibanamachine Aug 13, 2020

mbondyra added 3 commits August 13, 2020 19:51

typescript last mistake

a9e30ba

special cases

d8f6d6d

tests

eba40d7

mbondyra marked this pull request as ready for review August 14, 2020 10:32

mbondyra requested a review from a team August 14, 2020 10:32

Update mocks.ts

23a785d

Merge branch 'master' into lens/indexPatternFromIPService

8be86a4

flash1293 reviewed Aug 17, 2020

View reviewed changes

mbondyra added 2 commits August 18, 2020 12:44

fix rollup index

fcd423f

fix types

f01ce2d

flash1293 approved these changes Aug 18, 2020

View reviewed changes

mbondyra added 2 commits August 18, 2020 18:23

test: reuse mocks

ff6f69f

Merge commit 'de4b502cb31855b2c9c062ae97f99228138af27e' into lens/ind…

9085848

…exPatternFromIPService # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx

Merge branch 'master' into lens/indexPatternFromIPService

0eeed29

Merge branch 'master' into lens/indexPatternFromIPService

b4ef09f

kertal approved these changes Aug 21, 2020

View reviewed changes

mbondyra merged commit 23f46c9 into elastic:master Aug 21, 2020

mbondyra deleted the lens/indexPatternFromIPService branch August 21, 2020 09:35

mbondyra mentioned this pull request Aug 21, 2020

[7.x] [Lens] Use index pattern service instead saved object client (#74654) #75631

Merged

mbondyra added a commit to mbondyra/kibana that referenced this pull request Aug 21, 2020

[Lens] Use index pattern service instead saved object client (elastic…

e516c10

…#74654)

mbondyra added a commit that referenced this pull request Aug 21, 2020

[Lens] Use index pattern service instead saved object client (#74654) (…

060f627

…#75631)

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2020

[Lens] Use index pattern service instead saved object client (elastic…

aeb6573

…#74654)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Use index pattern service instead saved object client #74654

[Lens] Use index pattern service instead saved object client #74654

mbondyra commented Aug 10, 2020 •

edited

Loading

elasticmachine commented Aug 14, 2020

mbondyra commented Aug 17, 2020

flash1293 left a comment •

edited

Loading

mbondyra commented Aug 18, 2020 •

edited

Loading

flash1293 left a comment

flash1293 Aug 18, 2020

flash1293 Aug 18, 2020

mbondyra commented Aug 20, 2020

mbondyra commented Aug 21, 2020

kertal left a comment

kibanamachine commented Aug 21, 2020

[Lens] Use index pattern service instead saved object client #74654

[Lens] Use index pattern service instead saved object client #74654

Conversation

mbondyra commented Aug 10, 2020 • edited Loading

Summary

Field displayName changes

Checklist

elasticmachine commented Aug 14, 2020

mbondyra commented Aug 17, 2020

flash1293 left a comment • edited Loading

Choose a reason for hiding this comment

mbondyra commented Aug 18, 2020 • edited Loading

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Aug 18, 2020

Choose a reason for hiding this comment

flash1293 Aug 18, 2020

Choose a reason for hiding this comment

mbondyra commented Aug 20, 2020

mbondyra commented Aug 21, 2020

kertal left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 21, 2020

💚 Build Succeeded

Build metrics

page load bundle size

History

mbondyra commented Aug 10, 2020 •

edited

Loading

flash1293 left a comment •

edited

Loading

mbondyra commented Aug 18, 2020 •

edited

Loading