Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Show 'No data for this field' for empty field in accordion #73772

Merged
merged 6 commits into from
Aug 21, 2020
Merged

[Lens] Show 'No data for this field' for empty field in accordion #73772

merged 6 commits into from
Aug 21, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 30, 2020 •
edited
Loading

Summary

Fixes #72517

Fixes the bug of showing wrong message for empty fields as there no field preview available. Current behavior is buggy, the 'no data to display' popup doesn't show up:
image

That was the behavior before:
image

After speaking to @cchaos, we've decided going with the following design:
image

@cchaos, can you confirm the design change is correct?

@mbondyra mbondyra added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.10.0 7.9.0 labels Jul 30, 2020
@mbondyra mbondyra requested a review from a team July 30, 2020 07:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra changed the title [Lens] Do not show field data summaries icon/tooltip for empty fields [Lens] Do not show field 'click for a field preview' for empty fields Jul 30, 2020
@spalger spalger added v7.9.0 and removed 7.9.0 labels Jul 30, 2020
@mbondyra mbondyra marked this pull request as draft July 31, 2020 08:40
@mbondyra
Copy link
Contributor Author

mbondyra commented Aug 3, 2020

@elasticmachine merge upstream

@mbondyra mbondyra marked this pull request as ready for review August 3, 2020 07:28
@mbondyra
Copy link
Contributor Author

mbondyra commented Aug 5, 2020

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected. LGTM

@mbondyra
Copy link
Contributor Author

mbondyra commented Aug 5, 2020

Blocked by: #73226

@mbondyra mbondyra force-pushed the hide-details-for-empty-fields branch from b758ca5 to ea914d7 Compare August 19, 2020 10:28
@mbondyra mbondyra requested review from flash1293 and cchaos August 19, 2020 10:29
@mbondyra mbondyra changed the title [Lens] Do not show field 'click for a field preview' for empty fields [Lens] Show 'Not data for this field' for empty field in accordion Aug 19, 2020
@mbondyra mbondyra changed the title [Lens] Show 'Not data for this field' for empty field in accordion [Lens] Show 'No data for this field' for empty field in accordion Aug 19, 2020
@cchaos
Copy link
Contributor

cchaos commented Aug 19, 2020

I'm confused about situations like this where I feel like I'm getting conflicting messages. The tooltip tells me there's no data, but the popover shows me the distribution of a single value that exists in 95% of the sampled docs.

Screen Shot 2020-08-19 at 12 09 02 PM

@flash1293 flash1293 added v7.9.1 and removed v7.9.0 labels Aug 19, 2020
@flash1293
Copy link
Contributor

The "system fields" _id, _index and _type are not considered correctly in the field existence service at the moment, that's where this mismatch is coming from. It works correctly for actually empty fields, only these three are broken. I would suggest we create a separate issue for this.

Also, @wylieconlon do you know why it's showing 95%? Pretty sure the _index field is available on all documents.

@wylieconlon
Copy link
Contributor

The shard size we use for the sampler aggregation is 5000, and this data appears to be on a single shard. So 5000/5245 = 95%

@cchaos
Copy link
Contributor

cchaos commented Aug 19, 2020

The behavior looks good to me. @KOTungseth I think we could use some help with the copy.

Basically these empty fields can still be applied to their configurations, but the charts won't populate with data from it most likely because their current time range doesn't contain data for this field.

Screen Shot 2020-08-19 at 13 20 35 PM

  • The black tooltip is there to indicate why it's "grayed" they can still use it.
  • The popover then provides the longer description as to what it means to be "empty" and why there's no field preview.

@mbondyra mbondyra requested a review from KOTungseth August 21, 2020 09:44
@mbondyra
Copy link
Contributor Author

@flash1293 issue added here: #75632

@mbondyra
Copy link
Contributor Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and I'm fine with this state. It's now showing the "This field is empty because it doesn’t exist in the 500 sampled documents" popover for rollup fields as well, but I can address this separately on the rollup PR once this one is merged.

@mbondyra
Copy link
Contributor Author

Thanks @flash1293 for checking. I'll talk to @KOTungseth about the copy and merge it asap!

@KOTungseth
Copy link
Contributor

This is a great change! I have one small tweak: Can we move the noun to the front of the message? For example:

This field doesn't have data. Drag and drop to visualize.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lens 853.9KB +211.0B 853.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 5edba21 into elastic:master Aug 21, 2020
mbondyra added a commit to mbondyra/kibana that referenced this pull request Aug 21, 2020
@mbondyra
[Lens] Show 'No data for this field' for empty field in accordion (el…
ac15566 
…astic#73772)
@mbondyra mbondyra mentioned this pull request Aug 21, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 21, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
452f964 
* master: (71 commits)
  [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772)
  Skip failing lens test
  Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074)
  Fix returned payload by "search" usage collector (elastic#75340)
  [Security Solution] Fix missing key error (elastic#75576)
  Upgrade EUI to v27.4.1 (elastic#75240)
  Update datasets UI copy to data streams (elastic#75618)
  [Lens] Register saved object references (elastic#74523)
  [DOCS] Update links to Beats documentation (elastic#70380)
  [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616)
  [Usage Collection Schemas] Remove Legacy entries (elastic#75652)
  [Dashboard First] Lens Originating App Breadcrumb (elastic#75470)
  Improve login UI error message. (elastic#75642)
  [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579)
  [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163)
  Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536)
  [Console] Get ES Config from core (elastic#75406)
  [Uptime] Add delay in telemetry test (elastic#75162)
  [Lens] Use index pattern service instead saved object client (elastic#74654)
  Embeddable input (elastic#73033)
  ...
mbondyra added a commit that referenced this pull request Aug 25, 2020
@mbondyra @elasticmachine
[Lens] Show 'No data for this field' for empty field in accordion (#7…
1cae7b3 
…3772) (#75687)

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@cchaos cchaos Awaiting requested review from cchaos

@KOTungseth KOTungseth Awaiting requested review from KOTungseth

Assignees
No one assigned
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lens] do not show field data summaries icon/tooltip for empty fields
8 participants
@mbondyra @elasticmachine @cchaos @flash1293 @wylieconlon @KOTungseth @kibanamachine @spalger