Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Timeline] Add Empty view to the Timelines page #72576

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[Security Solution][Timeline] Add Empty view to the Timelines page #72576

merged 2 commits into from
Jul 21, 2020

Conversation

patrykkopycinski
Copy link
Contributor

Summary

OverviewEmpty was missing on the Timelines page

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 21, 2020
@patrykkopycinski patrykkopycinski requested review from a team as code owners July 21, 2020 07:36
@patrykkopycinski patrykkopycinski self-assigned this Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc
Copy link
Contributor

I've follow Glo's suggestion to create a no-data env:
go to: x-pack/test/security_solution_cypress/runner.ts comment line 20 (await esArchiver.load('auditbeat');) in line 25 change cypress:run for cypress:open , then in our directory run yarn cypress:run-as-ci when the cypress is open, you can access the Kibana instance in port 5620 with username elastic and password changeme

Empty view on timeline's page is showed properly.
Would we want to apply empty view to both detections alerts and detections rules pages as well?

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #72576 updated]

  • Start Time: 2020-07-21T11:27:58.314+0000

  • Duration: 4 min 19 sec

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +519.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 4b06a4e into elastic:master Jul 21, 2020
@patrykkopycinski patrykkopycinski deleted the fix/timeline-page-empty-view branch July 21, 2020 17:15
This was referenced Jul 21, 2020
Merged
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 21, 2020
@patrykkopycinski
[Security Solution][Timeline] Add Empty view to the Timelines page (e…
fdacc96 
…lastic#72576)
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 21, 2020
@patrykkopycinski
[Security Solution][Timeline] Add Empty view to the Timelines page (e…
7d155e0 
…lastic#72576)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
53aa8e9 
* master:
  [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576)
  [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563)
  Move manifest packageConfig mocks into security_solution plugin (elastic#72527)
  [QA][Code Coverage] Fixup Team Assignment (elastic#72467)
  [docs] remove references to tile map visualization in supported aggregations (elastic#72493)
  [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633)
  Only check that the event ids are the same in arrays (elastic#72624)
  Add doc titles to ES UI apps (elastic#71045)
  Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347)
  [APM] Disable flaky rum e2e’s (elastic#72614)
  Applying tiny fix from 72532 to main branch (elastic#72533)
  [APM] Update script with new roles/users (elastic#72599)
  [Security Solution] Add margin (elastic#72542)
  Migrated fixed_scroll karma tests to jest (elastic#72258)
  [ML] Handling data recognizer saved object errors (elastic#72447)
  [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310)
  [Task Manager] Batches the update operations in Task Manager  (elastic#71470)
patrykkopycinski added a commit that referenced this pull request Jul 21, 2020
@patrykkopycinski
[Security Solution][Timeline] Add Empty view to the Timelines page (#…
acbe581 
…72576) (#72697)
patrykkopycinski added a commit that referenced this pull request Jul 21, 2020
@patrykkopycinski
[Security Solution][Timeline] Add Empty view to the Timelines page (#…
c03f99f 
…72576) (#72696)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 22, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
fb1d793 
…feature-privileges

* alerting/consumer-based-rbac:
  [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576)
  [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563)
  renamed variable to make it clear the SO client is unsecured
  Move manifest packageConfig mocks into security_solution plugin (elastic#72527)
  [QA][Code Coverage] Fixup Team Assignment (elastic#72467)
  [docs] remove references to tile map visualization in supported aggregations (elastic#72493)
  [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633)
  Only check that the event ids are the same in arrays (elastic#72624)
  includes hidden params type in SO client
  Add doc titles to ES UI apps (elastic#71045)
  Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347)
  [APM] Disable flaky rum e2e’s (elastic#72614)
  Applying tiny fix from 72532 to main branch (elastic#72533)
  [APM] Update script with new roles/users (elastic#72599)
  [Security Solution] Add margin (elastic#72542)
  Migrated fixed_scroll karma tests to jest (elastic#72258)
  [ML] Handling data recognizer saved object errors (elastic#72447)
  [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310)
  [Task Manager] Batches the update operations in Task Manager  (elastic#71470)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patrykkopycinski @elasticmachine @angorayc @apmmachine @kibanamachine @MindyRS