[Monitoring] Fix the messaging around needing TLS enabled #72310

chrisronline · 2020-07-17T17:03:52Z

Relates to #71846

Updates the copy per this comment

I changed it slightly and made it so we show the same error message in all error scenarios.

cc @lcawl @gchaps

elasticmachine · 2020-07-17T17:03:55Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic · 2020-07-20T16:34:34Z

x-pack/plugins/monitoring/public/alerts/lib/security_toasts.tsx

-  } else if (!hasPermanentEncryptionKey) {
-    showEncryptionError();
-  }
+  showTlsAndEncryptionError();


I think we should still check for these cases:

Suggested change

showTlsAndEncryptionError();

if (!isSufficientlySecure || !hasPermanentEncryptionKey) {

showTlsAndEncryptionError();

}

igoristic · 2020-07-20T16:35:29Z

x-pack/plugins/monitoring/public/alerts/lib/security_toasts.tsx

@@ -30,11 +30,10 @@ const showTlsAndEncryptionError = () => {
      <div>
        <p>
          {i18n.translate('xpack.monitoring.healthCheck.tlsAndEncryptionError', {
-            defaultMessage: `You must enable Transport Layer Security between Kibana and Elasticsearch 
-              and configure an encryption key in your kibana.yml file to use the Alerting feature.`,
+            defaultMessage: `Stack monitoring alerts require Transport Layer Security between Kibana and Elasticsearch and an encryption key in your kibana.yml file.`,


Suggested change

defaultMessage: `Stack monitoring alerts require Transport Layer Security between Kibana and Elasticsearch and an encryption key in your kibana.yml file.`,

defaultMessage: `Stack monitoring alerts require Transport Layer Security between Kibana and Elasticsearch, and an encryption key in your kibana.yml file.`,

igoristic

I think this looks good 👍

Added a couple of optional suggestions though

gchaps

LGTM

chrisronline · 2020-07-20T17:49:25Z

@igoristic Made those changes. Do you mind double checking this?

igoristic

Looking good now 👍

kibanamachine · 2020-07-20T20:01:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5c2fe23

Build metrics

async chunks size

id	value	diff	baseline
monitoring	1.1MB	-3.0KB	1.1MB

History

💔 Build #63070 failed ac423ab
💚 Build #62732 succeeded 9135ccb
💔 Build #62700 failed 2f47951

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…72627) * Fix the copy * Fix type issues * PR feedback * Add missing code

chrisronline · 2020-07-21T15:06:36Z

Backport:

7.x: d00c09e

* master: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)

…feature-privileges * alerting/consumer-based-rbac: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) renamed variable to make it clear the SO client is unsecured Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) includes hidden params type in SO client Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)

Fix the copy

2f47951

chrisronline added release_note:enhancement review Team:Monitoring Stack Monitoring team v8.0.0 v7.10.0 labels Jul 17, 2020

chrisronline requested review from igoristic and a team July 17, 2020 17:03

chrisronline self-assigned this Jul 17, 2020

chrisronline mentioned this pull request Jul 17, 2020

[Monitoring] Added a case for Alerting if security/ssl is disabled #71846

Merged

chrisronline added 2 commits July 17, 2020 14:47

Merge remote-tracking branch 'elastic/master' into monitoring/fixed_copy

7c61bfa

Fix type issues

9135ccb

igoristic reviewed Jul 20, 2020

View reviewed changes

igoristic approved these changes Jul 20, 2020

View reviewed changes

gchaps approved these changes Jul 20, 2020

View reviewed changes

PR feedback

f5f8762

chrisronline requested a review from igoristic July 20, 2020 17:49

chrisronline added 2 commits July 20, 2020 13:50

Merge remote-tracking branch 'elastic/master' into monitoring/fixed_copy

ac423ab

Add missing code

5c2fe23

igoristic approved these changes Jul 20, 2020

View reviewed changes

chrisronline merged commit c63ab91 into elastic:master Jul 21, 2020

chrisronline deleted the monitoring/fixed_copy branch July 21, 2020 13:12

chrisronline mentioned this pull request Jul 21, 2020

[7.x] [Monitoring] Fix the messaging around needing TLS enabled (#72310) #72627

Merged

chrisronline added a commit that referenced this pull request Jul 21, 2020

[Monitoring] Fix the messaging around needing TLS enabled (#72310) (#…

d00c09e

…72627) * Fix the copy * Fix type issues * PR feedback * Add missing code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] Fix the messaging around needing TLS enabled #72310

[Monitoring] Fix the messaging around needing TLS enabled #72310

chrisronline commented Jul 17, 2020 •

edited

Loading

elasticmachine commented Jul 17, 2020

igoristic Jul 20, 2020 •

edited

Loading

igoristic Jul 20, 2020

igoristic left a comment

gchaps left a comment

chrisronline commented Jul 20, 2020

igoristic left a comment

kibanamachine commented Jul 20, 2020

chrisronline commented Jul 21, 2020

	defaultMessage: `Stack monitoring alerts require Transport Layer Security between Kibana and Elasticsearch and an encryption key in your kibana.yml file.`,
	defaultMessage: `Stack monitoring alerts require Transport Layer Security between Kibana and Elasticsearch, and an encryption key in your kibana.yml file.`,

[Monitoring] Fix the messaging around needing TLS enabled #72310

[Monitoring] Fix the messaging around needing TLS enabled #72310

Conversation

chrisronline commented Jul 17, 2020 • edited Loading

elasticmachine commented Jul 17, 2020

igoristic Jul 20, 2020 • edited Loading

Choose a reason for hiding this comment

igoristic Jul 20, 2020

Choose a reason for hiding this comment

igoristic left a comment

Choose a reason for hiding this comment

gchaps left a comment

Choose a reason for hiding this comment

chrisronline commented Jul 20, 2020

igoristic left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 20, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

chrisronline commented Jul 21, 2020

chrisronline commented Jul 17, 2020 •

edited

Loading

igoristic Jul 20, 2020 •

edited

Loading