-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipeline/commitStatus] update commit status in baseline-capture job #72366
[pipeline/commitStatus] update commit status in baseline-capture job #72366
Conversation
9e377e9
to
73f21b0
Compare
73f21b0 verified that the commit status worked |
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs an error catch
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
* master: (28 commits) allow some env settings for ingest manager (elastic#72544) Add inspector for VEGA (elastic#70941) chore(NA): fix grunt task for test:coverage (elastic#72539) Archive e2e test results in ES (elastic#72575) preserve 401 errors from new es client (elastic#71248) [SIEM][Detections] Updates text for severity and risk_score overrides (elastic#72244) fixing error occurences tooltip (elastic#72425) use KibanaClient interface instead of Client for new client interface (elastic#72388) [APM] Handle ML errors (elastic#72316) [Discover] Improve histogram tests (elastic#72235) [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540) [pre-req] Move .storybook to storybook; standardize files (elastic#72384) [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538) [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468) [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336) [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509) Fix long combo box items breaking out of flex item width (elastic#72512) [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366) [Security Solution][Resolver] Update the resolver element ref on scroll events if the position of the element has changed within the page (elastic#72461) [Maps] auto-fit to data bounds (elastic#72129) ...
…feature-privileges * alerting/consumer-based-rbac: (30 commits) removed uneeded tests expclude security wrapper in SO client passed to ActionsClient allow some env settings for ingest manager (elastic#72544) Add inspector for VEGA (elastic#70941) chore(NA): fix grunt task for test:coverage (elastic#72539) Archive e2e test results in ES (elastic#72575) preserve 401 errors from new es client (elastic#71248) [SIEM][Detections] Updates text for severity and risk_score overrides (elastic#72244) fixing error occurences tooltip (elastic#72425) use KibanaClient interface instead of Client for new client interface (elastic#72388) [APM] Handle ML errors (elastic#72316) [Discover] Improve histogram tests (elastic#72235) [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540) [pre-req] Move .storybook to storybook; standardize files (elastic#72384) [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538) [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468) [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336) [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509) Fix long combo box items breaking out of flex item width (elastic#72512) [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366) ...
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…lastic#72366) Co-authored-by: spalger <[email protected]>
…lastic#72366) Co-authored-by: spalger <[email protected]>
…lastic#72366) Co-authored-by: spalger <[email protected]> (cherry picked from commit a221e04)
… and [pipeline/commitStatus] update commit status in baseline-capture job (#72366) (#72981) * [baseline/capture] use high-memory nodes with ramDisks (#71894) Co-authored-by: spalger <[email protected]> * [pipeline/commitStatus] update commit status in baseline-capture job (#72366) Co-authored-by: spalger <[email protected]> (cherry picked from commit a221e04) Co-authored-by: spalger <[email protected]>
…72366) (#72978) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
…72366) (#72979) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
I noticed that since we've switched to using #69451 we have been leaving "pending" commit statuses on all commits to tracked branches. This PR reworks the githubCommitStatus helpers a little to accept passing a commit and context to more methods, and adds a helper that wraps a build and calls the right helpers on both sides of a closure. This new method now wraps the
baseline-capture
job so that status is updated and completed when the job passes/fails.