Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Handle ML errors #72316

Merged
merged 7 commits into from
Jul 21, 2020
Merged

[APM] Handle ML errors #72316

merged 7 commits into from
Jul 21, 2020

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Jul 17, 2020 •
edited
Loading

image

@sorenlouv sorenlouv requested a review from a team as a code owner July 17, 2020 17:27
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 20, 2020
@sorenlouv
Copy link
Member Author

Thanks for the feedback @cauemarcondes. I should have addressed all of it now.

cauemarcondes
cauemarcondes reviewed Jul 20, 2020
View reviewed changes
x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/jobs_list.tsx Outdated
}
)}
</>
// A known erorr occured. Show specific error message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Suggested change
// A known erorr occured. Show specific error message
// A known error occurred. Show specific error message

cauemarcondes
cauemarcondes approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic reviewed Jul 20, 2020
View reviewed changes
x-pack/plugins/apm/common/anomaly_detection.ts Outdated
warning = 'warning',
}

export function getSeverity(score?: number) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is very similar to some utility functions in the ML plugin which are already being shared.
If possible, it makes sense to me that you to use our functions just in case we decide that the anomaly scoring thresholds should change.
getSeverityType and ANOMALY_SEVERITY are available from ....../plugins/ml/public

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's great. I'll take a look. Thanks for jumping in @jgowdyelastic !

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 3.7MB +2.9KB 3.7MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 511e454 into elastic:master Jul 21, 2020
@sorenlouv sorenlouv deleted the handle-ml-errors branch July 21, 2020 06:41
@sorenlouv sorenlouv mentioned this pull request Jul 21, 2020
Merged
@sorenlouv
Copy link
Member Author

💚 Backport successful

The PR was backported to the following branches:

@sorenlouv sorenlouv mentioned this pull request Jul 21, 2020
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (elastic#72316)
2b6e254 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (elastic#72316)
d6ce883 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (elastic#72316)
886f225 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
@kibanamachine kibanamachine mentioned this pull request Jul 21, 2020
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (elastic#72316)
e4a1dac 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
This was referenced Jul 21, 2020
Closed
Closed
kibanamachine pushed a commit that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (#72316)
7a17e73 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
sorenlouv added a commit that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (#72316) (#72577)
57d9b81 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
sorenlouv added a commit that referenced this pull request Jul 21, 2020
@sorenlouv
[APM] Handle ML errors (#72316) (#72574)
4ef1ac4 
* [APM] Handle ML errors

* Add capability check

* Improve test

* Address Caue’s feedback

* Move getSeverity

* Fix tsc

* Fix copy
This was referenced Jul 21, 2020
Closed
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
407b09a 
* master: (28 commits)
  allow some env settings for ingest manager (elastic#72544)
  Add inspector for VEGA (elastic#70941)
  chore(NA): fix grunt task for test:coverage (elastic#72539)
  Archive e2e test results in ES (elastic#72575)
  preserve 401 errors from new es client (elastic#71248)
  [SIEM][Detections] Updates text for severity and risk_score overrides  (elastic#72244)
  fixing error occurences tooltip (elastic#72425)
  use KibanaClient interface instead of Client for new client interface (elastic#72388)
  [APM] Handle ML errors (elastic#72316)
  [Discover] Improve histogram tests (elastic#72235)
  [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540)
  [pre-req] Move .storybook to storybook; standardize files (elastic#72384)
  [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538)
  [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468)
  [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336)
  [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509)
  Fix long combo box items breaking out of flex item width (elastic#72512)
  [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366)
  [Security Solution][Resolver] Update the resolver element ref on scroll events if the position of the element has changed within the page (elastic#72461)
  [Maps] auto-fit to data bounds (elastic#72129)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
8545f64 
…feature-privileges

* alerting/consumer-based-rbac: (30 commits)
  removed uneeded tests
  expclude security wrapper in SO client passed to ActionsClient
  allow some env settings for ingest manager (elastic#72544)
  Add inspector for VEGA (elastic#70941)
  chore(NA): fix grunt task for test:coverage (elastic#72539)
  Archive e2e test results in ES (elastic#72575)
  preserve 401 errors from new es client (elastic#71248)
  [SIEM][Detections] Updates text for severity and risk_score overrides  (elastic#72244)
  fixing error occurences tooltip (elastic#72425)
  use KibanaClient interface instead of Client for new client interface (elastic#72388)
  [APM] Handle ML errors (elastic#72316)
  [Discover] Improve histogram tests (elastic#72235)
  [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540)
  [pre-req] Move .storybook to storybook; standardize files (elastic#72384)
  [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538)
  [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468)
  [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336)
  [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509)
  Fix long combo box items breaking out of flex item width (elastic#72512)
  [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sorenlouv @elasticmachine @kibanamachine @jgowdyelastic @cauemarcondes