[ML] DF Analytics: stop status polling when job stopped #71159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
60 tasks
qn895
reviewed
Jul 8, 2020
| @@ -22,6 +22,7 @@ import { DataFrameAnalyticsId } from '../../../../common/analytics'; | |||
|
|
|||
| export const PROGRESS_REFRESH_INTERVAL_MS = 1000; | |||
| const FAILED = 'failed'; | |||
| const STOPPED = 'stopped'; | |||
There was a problem hiding this comment.
Think both of these might already be defined by DATA_FRAME_TASK_STATE
There was a problem hiding this comment.
Or alternatively can you use the JOB_STATE values from common/constants/states.ts ?
There was a problem hiding this comment.
Good catch - updated in d77fbbbe42d984d53aafe1462a9b5669fbc8a435
|
Tested and LGTM. Just left a minor comment. |
qn895
approved these changes
Jul 9, 2020
peteharverson
approved these changes
Jul 9, 2020
| @@ -22,6 +22,7 @@ import { DataFrameAnalyticsId } from '../../../../common/analytics'; | |||
|
|
|||
| export const PROGRESS_REFRESH_INTERVAL_MS = 1000; | |||
| const FAILED = 'failed'; | |||
| const STOPPED = 'stopped'; | |||
There was a problem hiding this comment.
Or alternatively can you use the JOB_STATE values from common/constants/states.ts ?
alvarezmelissa87
force-pushed
the
ml-dfanalytics-stop-polling
branch
from
1d22f2e to
7f72f74
Compare
alvarezmelissa87
force-pushed
the
ml-dfanalytics-stop-polling
branch
from
d77fbbb to
469e59f
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 10, 2020
* clear interval if job stopped * ensure analysisFieldsTable error messages up to date * use shared constant for job state
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 10, 2020
…11y-overlay * 'master' of github.com:elastic/kibana: (33 commits) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI Deduplication of entries and items before sending to endpoint (elastic#71297) [services/remote/webdriver] fix eslint error (elastic#71346) send slack notifications on visual baseline failures fix visual regression job (elastic#70999) [Ingest Manager] Add schema to usageCollector. (elastic#71219) [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279) [Ingest Manager] Fix limited packages incorrect response (elastic#71292) Support multiple features declaring same properties (elastic#71106) [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183) [DOCS] Clarify trial subscription levels (elastic#70636) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 13, 2020
* master: (78 commits) Bump lodash package version (elastic#71392) refactor: 💡 use allow-list in AppArch codebase (elastic#71400) improve bugfix 7198 test stability (elastic#71250) [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198) [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172) [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269) [Security Solution] Allow to configure Event Renderers settings (elastic#69693) Fix a11y keyboard overlay (elastic#71214) [APM] UI text updates (elastic#71333) [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113) [SIEM] fix tooltip of notes (elastic#71342) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #66661
Fixes #70714
This PR
AnalysisFieldsTable(includes table) error messages are up to date by clearing out old unsupported field error when no fields are selectedChecklist
Delete any items that are not applicable to this PR.