Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM Dashboard] Chart breakdowns #69420

Merged
merged 93 commits into from
Jun 29, 2020
Merged

[RUM Dashboard] Chart breakdowns #69420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
f9c20a1
added rum filters and tab
shahzad31 Jun 3, 2020
1f75371
update
shahzad31 Jun 3, 2020
f1c9bcf
move range filter into common
shahzad31 Jun 5, 2020
9f615df
Merge branch 'master' into rum-filters
shahzad31 Jun 5, 2020
2214001
fix issue in tab condition
shahzad31 Jun 5, 2020
eaf461c
Merge branch 'master' into rum-filters
shahzad31 Jun 5, 2020
95b510b
add clinet
shahzad31 Jun 5, 2020
b818fbd
update
shahzad31 Jun 8, 2020
ac24241
Merge branch 'master' into rum-filters
shahzad31 Jun 8, 2020
3cd29fb
added transactiont type filter
shahzad31 Jun 8, 2020
bae67c2
Merge branch 'rum-filters' into client-metrics
shahzad31 Jun 8, 2020
5a6c41a
update
shahzad31 Jun 8, 2020
a3c83cc
Merge branch 'master' into client-metrics
shahzad31 Jun 8, 2020
60ac2eb
update
shahzad31 Jun 9, 2020
a587d82
Merge branch 'master' into client-metrics
shahzad31 Jun 9, 2020
6496237
Merge branch 'master' into client-metrics
shahzad31 Jun 10, 2020
fd6d22a
update
shahzad31 Jun 10, 2020
89a93ed
update
shahzad31 Jun 10, 2020
c1a9ef2
added filter
shahzad31 Jun 10, 2020
e062152
Merge branch 'master' into client-metrics
shahzad31 Jun 11, 2020
d77652c
update
shahzad31 Jun 11, 2020
1d0afcc
update
shahzad31 Jun 11, 2020
f1259a7
fixed
shahzad31 Jun 11, 2020
fb0782b
Merge branch 'master' into client-metrics
shahzad31 Jun 11, 2020
638920d
added rum tests
shahzad31 Jun 11, 2020
b0b11e5
Merge branch 'master' into client-metrics
shahzad31 Jun 12, 2020
9dc10c5
update and added reset zoom button
shahzad31 Jun 12, 2020
b2b444a
snapshot
shahzad31 Jun 12, 2020
6a9749e
Merge branch 'master' into client-metrics
shahzad31 Jun 12, 2020
8702dc9
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 14, 2020
3c8f802
added breakdown filter button
shahzad31 Jun 15, 2020
ebf9761
Merge branch 'master' into client-metrics
shahzad31 Jun 15, 2020
e72de7b
update
shahzad31 Jun 15, 2020
746ef6f
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 15, 2020
a0176da
improve responsiveness
shahzad31 Jun 15, 2020
3c769a7
update
shahzad31 Jun 15, 2020
9e0b508
rename impression treds
shahzad31 Jun 15, 2020
c7d1521
update tooltip
shahzad31 Jun 15, 2020
1d94b3f
update
shahzad31 Jun 15, 2020
483d8fd
Merge branch 'master' into client-metrics
shahzad31 Jun 15, 2020
9ffcabb
Merge branch 'master' into client-metrics
shahzad31 Jun 16, 2020
ee3616e
update test
shahzad31 Jun 16, 2020
7e18010
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 16, 2020
20c779e
Suggested design improvements
formgeist Jun 16, 2020
bcb8ff8
update
shahzad31 Jun 17, 2020
1b8ef95
Merge branch 'master' into client-metrics
shahzad31 Jun 17, 2020
a05e6d6
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 17, 2020
352621a
fix types
shahzad31 Jun 18, 2020
a0a7a44
Merge branch 'master' into client-metrics
shahzad31 Jun 18, 2020
7056e40
fix e2e
shahzad31 Jun 18, 2020
92098c0
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 18, 2020
fc33078
fix issue with rum timing
shahzad31 Jun 18, 2020
9529d76
update snapshot
shahzad31 Jun 18, 2020
0733c7c
Merge pull request #2 from formgeist/client-metrics-ui-fixes
shahzad31 Jun 18, 2020
d3149ea
update snapshot
shahzad31 Jun 18, 2020
14e8851
fix types
shahzad31 Jun 18, 2020
9d143a5
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 18, 2020
b232189
update
shahzad31 Jun 18, 2020
627e217
Merge branch 'master' into client-metrics
shahzad31 Jun 18, 2020
bff7fe9
Merge branch 'master' into client-metrics
elasticmachine Jun 18, 2020
7206ffc
Merge branch 'client-metrics' of https://github.com/shahzad31/kibana …
shahzad31 Jun 18, 2020
4ba1889
fix issue came out of bad merge
shahzad31 Jun 18, 2020
bb2ae2e
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 18, 2020
a15b3f5
Merge branch 'client-metrics' into chart-breakdowns
shahzad31 Jun 18, 2020
291c30c
update
shahzad31 Jun 18, 2020
9ab0659
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 18, 2020
aaf36d7
commit
shahzad31 Jun 19, 2020
b5746f3
test
shahzad31 Jun 21, 2020
f9fe8e3
up
shahzad31 Jun 22, 2020
640695f
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 23, 2020
5892c9d
fix theme
shahzad31 Jun 23, 2020
ba2823d
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 23, 2020
5d267fe
update
shahzad31 Jun 25, 2020
986e9a5
upate
shahzad31 Jun 25, 2020
3797388
update
shahzad31 Jun 25, 2020
1690d15
update
shahzad31 Jun 25, 2020
c5b71a6
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 25, 2020
a11f183
update
shahzad31 Jun 25, 2020
9df90e9
added types
shahzad31 Jun 25, 2020
1b5af10
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 25, 2020
4b90edb
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 26, 2020
059ac73
Fix PR feedback
shahzad31 Jun 26, 2020
2d686b0
PR feedbck
shahzad31 Jun 26, 2020
e45f12f
update i18c
shahzad31 Jun 26, 2020
f12173b
update scenerios
shahzad31 Jun 26, 2020
b1573bd
remove unnecessary changes
shahzad31 Jun 26, 2020
e5f6628
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 26, 2020
041d90c
Merge branch 'master' into chart-breakdowns
elasticmachine Jun 26, 2020
a5ca6e2
Merge branch 'master' into chart-breakdowns
elasticmachine Jun 29, 2020
12937e1
update bdd spec
shahzad31 Jun 29, 2020
623a800
Merge branch 'chart-breakdowns' of https://github.com/shahzad31/kiban…
shahzad31 Jun 29, 2020
9d6ecd9
Merge branch 'master' into chart-breakdowns
shahzad31 Jun 29, 2020
fe89c69
update scenerios
shahzad31 Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions x-pack/plugins/apm/e2e/cypress/integration/rum_dashboard.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,32 @@ Feature: RUM Dashboard
Then should redirect to rum dashboard
And should have correct client metrics

Scenario: Page load distribution
Scenario: Rum page filters
Given a user click the filter
When the user select the filter
And user applies the selected filter
Then it filters the client metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about this?

Scenario: Rum page filters
    When the user filters by "put-here-your-filter-name"
    Then the client metrics are filtered

The Given part could not be necessary, but the When one is key:

  • Given: preparation of the test before the scenario
  • When: the action that triggers the scenario
  • Then: the outcome/output to be verified after the scenario

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have updated this one as well.


Scenario: Page load distribution percentiles
Given a user browses the APM UI application for RUM Data
When the user inspects the real user monitoring tab
Then should redirect to rum dashboard
And should display percentile for page load chart
And should display tooltip on hover
And should display chart legend

Scenario: Page load distribution chart tooltip
Given a user browses the APM UI application for RUM Data
When the user inspects the real user monitoring tab
Then should redirect to rum dashboard
And should display tooltip on hover

Scenario: Page load distribution chart legends
Given a user browses the APM UI application for RUM Data
When the user inspects the real user monitoring tab
Then should redirect to rum dashboard
And should display chart legend

Scenario: Breakdown filter
Given a user click page load breakdown filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is another scenario

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a BDD sequence, there is a Given/When/Then pattern that should be repeated across different scenarios.

When the user selected the breakdown
Then breakdown series should appear in chart

Given a user click the filter
When the user select the filter
And user applies the selected filter
Then it filters the client metrics
16 changes: 10 additions & 6 deletions x-pack/plugins/apm/e2e/cypress/integration/snapshots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,19 @@ module.exports = {
"2": "0.07 sec",
"3": "0.01 sec"
},
"Page load distribution": {
"Page load distribution percentiles": {
"1": "50th",
"2": "75th",
"3": "90th",
"4": "95th",
"5": "Overall",
"6": "15 ",
"7": "0.07 sec",
"8": "0.01 sec"
"4": "95th"
},
"Rum page filters": {
"1": "15 ",
"2": "0.07 sec",
"3": "0.01 sec"
},
"Page load distribution chart legends": {
"1": "Overall"
}
}
}