[RUM Dashboard] Chart breakdowns #69420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
Jun 26, 2020
Comment on lines
10
to
13
| Given a user click the filter | ||
| When the user select the filter | ||
| And user applies the selected filter | ||
| Then it filters the client metrics |
There was a problem hiding this comment.
Wdyt about this?
Scenario: Rum page filters
When the user filters by "put-here-your-filter-name"
Then the client metrics are filteredThe Given part could not be necessary, but the When one is key:
- Given: preparation of the test before the scenario
- When: the action that triggers the scenario
- Then: the outcome/output to be verified after the scenario
There was a problem hiding this comment.
i have updated this one as well.
|
On dev-next I still don't see any options in the filter dropdowns and breaking down by any attribute just shows "Overall." Is this supposed to show the same data as the opbeans-rum service on the services overview? I'm a bit confused about what I'm looking at. Is there a cluster with better data? Is something wrong with the dev-next data? |
@smith dev-next has some bug for recent rum data, try increasing date range to last 90 days etc to see filters/breakdowns. you can also connect to falabella cluster to see more filters/breakdowns. |
|
@elasticmachine merge upstream |
smith
approved these changes
Jun 26, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
shahzad31
force-pushed
the
chart-breakdowns
branch
from
623a800 to
12937e1
Compare
|
After our zoom call, we are not going to block this one for the BDD steps, and will continue working on the BDD scenarios in a follow-up PR. Thanks! |
mdelapenya
approved these changes
Jun 29, 2020
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
shahzad31
added a commit
that referenced
this pull request
Jul 3, 2020
* [RUM Dashboard] Chart breakdowns (#69420) Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]> * added timout for cypress get Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #69712
This PR adds breakdown for Page Load Distributon and Page views chart, user can breakdown charts based on Browser, Location, Device and OS.