Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize DFA job creation #68495

Merged
merged 3 commits into from
Jun 9, 2020
Merged

[ML] Functional tests - stabilize DFA job creation #68495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
853956c
Add missing await
pheyos Jun 8, 2020
fb20952
Merge branch 'master' into stabilize_dfa_creation
pheyos Jun 8, 2020
df94a65
Re-enabled classification and regression creation tests
pheyos Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ export default function ({ getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const ml = getService('ml');

// flaky test, see https://github.com/elastic/kibana/issues/68356
describe.skip('classification creation', function () {
describe('classification creation', function () {
before(async () => {
await esArchiver.loadIfNeeded('ml/bm_classification');
await ml.testResources.createIndexPatternIfNeeded('ft_bank_marketing', '@timestamp');
Expand Down Expand Up @@ -66,7 +65,7 @@ export default function ({ getService }: FtrProviderContext) {
});

it('selects the source data and loads the job wizard page', async () => {
ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
await ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
});

it('selects the job type', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function ({ getService }: FtrProviderContext) {
});

it('selects the source data and loads the job wizard page', async () => {
ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
await ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
});

it('selects the job type', async () => {
Expand Down
5 changes: 2 additions & 3 deletions x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ export default function ({ getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const ml = getService('ml');

// flaky test, see https://github.com/elastic/kibana/issues/68352
describe.skip('regression creation', function () {
describe('regression creation', function () {
before(async () => {
await esArchiver.loadIfNeeded('ml/egs_regression');
await ml.testResources.createIndexPatternIfNeeded('ft_egs_regression', '@timestamp');
Expand Down Expand Up @@ -66,7 +65,7 @@ export default function ({ getService }: FtrProviderContext) {
});

it('selects the source data and loads the job wizard page', async () => {
ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
await ml.jobSourceSelection.selectSourceForAnalyticsJob(testData.source);
});

it('selects the job type', async () => {
Expand Down