Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize DFA job creation #68495

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jun 8, 2020

Summary

This PR stabilizes the classification and regression creation tests.

Closes #68352
Closes #68356
Closes #68476

@pheyos pheyos self-assigned this Jun 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Jun 8, 2020

Reproduced the flaky test execution before this fix in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/514/ => 6 failures in 50 runs.

Checked test stability again with this fix in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/523/ => no failure in 50 runs.

@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.9.0 v8.0.0 labels Jun 8, 2020
@pheyos pheyos marked this pull request as ready for review June 8, 2020 12:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 5377dbb into elastic:master Jun 9, 2020
@pheyos pheyos deleted the stabilize_dfa_creation branch June 9, 2020 09:26
pheyos added a commit to pheyos/kibana that referenced this pull request Jun 9, 2020
This PR stabilizes the classification and regression creation tests.
pheyos added a commit that referenced this pull request Jun 9, 2020
This PR stabilizes the classification and regression creation tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2020
* master: (37 commits)
  [DOCS] Adds documentation for drilldowns (elastic#68122)
  [Telemetry] telemetry.sendUsageFrom: "server" by default (elastic#68071)
  [ML] Transforms: Support sub-aggregations (elastic#68306)
  Fixed pre-configured docs link points to the wrong page and functional tests configs (elastic#68606)
  [Ingest Manager] Update queries from `stream.*` to `dataset.*` (elastic#68322)
  Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (elastic#68602)
  Convert Index Templates API routes to snakecase. (elastic#68463)
  [SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (elastic#68441)
  [Ingest] OpenAPI spec file (elastic#68323)
  chore(NA): skip apis Endpoint plugin Endpoint policy api (elastic#68638)
  bumping makelogs version to v6.0.0 (elastic#66163)
  [SIEM] Add create template button (elastic#66613)
  Bump websocket-extensions from 0.1.3 to 0.1.4 (elastic#68414)
  [ML] Sample data modules - use event.dataset instead of index name (elastic#68538)
  [ML] Functional tests - fix job validation API test with maxModelMemoryLimit (elastic#68501)
  [ML] Functional tests - stabilize DFA job creation (elastic#68495)
  [TSVB] Allows the user to change the tooltip mode (elastic#67775)
  chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (elastic#68613)
  chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (elastic#68596)
  [SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common  (elastic#68127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment