-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint] Encode the index of the alert in the id response #66919
Merged
jonathan-buttner
merged 3 commits into
elastic:master
from
jonathan-buttner:fix-alerts-data-stream-get
May 18, 2020
Merged
[Endpoint] Encode the index of the alert in the id response #66919
jonathan-buttner
merged 3 commits into
elastic:master
from
jonathan-buttner:fix-alerts-data-stream-get
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Endpoint
Elastic Endpoint feature
v7.9.0
labels
May 18, 2020
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
jonathan-buttner
changed the title
Encode the index of the alert in the id response
[Endpoint] Encode the index of the alert in the id response
May 18, 2020
madirey
approved these changes
May 18, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
that referenced
this pull request
May 19, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 19, 2020
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Endpoint
Elastic Endpoint feature
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retrieving alerts from ES is currently not working because of data streams. To reproduce this issue:
This will not happen when using the resolver data generator because it uses a mapping file which forces the index to not use data streams.
You should see the following in the UI
Alert UI Failure
The issue is that the ingest manager leverages v2 templates and data streams for the data sent by an endpoint. The endpoint binary is configured to send event data and alerts to
event-endpoint-1
. Instead of creating a normal index in ES, a data stream will be created and the actual index will be something likeevents-endpoint-1-000001
. When the alert details server code tries to retrieve the alert it uses a hard coded index value here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/endpoint/common/alert_constants.ts#L19 (events-endpoint-1
) and uses the ES Get api for retrieving the alert by it's ID.This fails with the following error:
To solve this, the index will now be encoded in the response
id
field.Testing
Connect a live endpoint and trigger an alert. You should be able to see the alert in resolver.