-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Consolidate Server Type Defs, move some out of Legacy #66144
[Reporting] Consolidate Server Type Defs, move some out of Legacy #66144
Conversation
2b340d4
to
84facc7
Compare
438479f
to
8b0c99f
Compare
f5b81e8
to
31e1407
Compare
31e1407
to
6e7725e
Compare
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
import { CancellationToken } from '../../../../../plugins/reporting/common'; | ||
import { JobDocPayload, JobParamPostPayload, ScrollConfig } from '../../server/types'; | ||
|
||
export type RawValue = string | object | null | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, this type is pretty wide open, hopefully we can narrow it down at some point...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…astic#66144) * [Reporting] consolidate server types, move some to NP * Revert touching routes code Co-authored-by: Elastic Machine <[email protected]>
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
…cy (#66144) (#66947) * [Reporting] Consolidate Server Type Defs, move some out of Legacy (#66144) * [Reporting] consolidate server types, move some to NP * Revert touching routes code Co-authored-by: Elastic Machine <[email protected]> * fix ts * fix ts Co-authored-by: Elastic Machine <[email protected]>
Depends on Reporting route migration.
This PR changes around imports, moving most out of files named
types.d.ts
and intoindex.ts
. Many other definitions that do not referencelegacy
have been moved to the New Platform area of Reporting code.Why this PR is useful
It starts to move code in the direction of New Platform. Consolidating the type definitions means placing the definitions closer to where they're important. That makes it simpler to identify entire modules that can be relocated.
These changes provide a way for there to be a smaller next PR to move server libs to NP. The
ExportTypesRegistry
andLevelLogger
would be good options to move to NP next.Summary
cancellation_token
, as moved types depend on ittypes.d.ts
files by moving type definitions where they fit best, or toindex.ts
files for module scopeLevelLogger
asLogger
because it conflicts with a core type name