-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] auto-fit to data bounds #66452
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
@@ -489,7 +518,7 @@ export class VectorLayer extends AbstractLayer { | |||
layerName, | |||
style, | |||
dynamicStyleProps, | |||
registerCancelCallback, | |||
registerCancelCallback.bind(null, requestToken), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug while working on this PR where style meta did not properly register callback.
💔 Build Failed
Failed CI StepsTo update your PR or re-run it, just comment with: |
I've been doing quite a lot of testing and I think the only thing I've found is that the filtering is not working for EMS boundaries, but not sure if it's because there's apparently an unrelated bug that prevents run the Checked on clusters, heatmaps, grids, and point to point. |
That is an existing behavior on master and not related to this PR. Mind creating an issue for it and I can fix outside of this PR? |
Another issue is that somehow this setting is conflicting with Kibana Bar filters for the Point to Point layer. Without the setting enabled I can create filters from the bar without problems but once enabled, the map freezes when searching in the bar. I can see a |
temporarily closing. I am going to pull the getBounds data request into its own PR to separate the bulk of the changes from the auto-complete. Will re-open once the prior has been merged and this PR is updated to latest |
Auto fit to bounds changes pulled out into #72129 |
Fixes #2054, #32738, #53831
This PR adds a new map setting that will auto fit the map to data bounds.
PR adds data request for bounds for the following reasons
cc @alexfrancoeur