-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate Maps: auto fit data bounds #2054
Comments
+1 |
I like this one too :-) |
👍 |
I just issued a pull request to fix this. #2708 |
@jmleoni - Good on you! I just hold a presentation of Kibana to colleagues and they all start laughing when I had to reload the page and clicking like a mad dog all over the 9 maps on the dashboard! ...at least it was entertaining! ;) 👍 |
what's going on with this issue? |
Right now it my fix works, but is not being merged because it lacks automated tests. |
@jmleoni - A bit off-topic, and maybe it's just a language thing (English is not my first language!), but I hope you are not suggesting "lack of tests" is a minor flow in a piece of code... Code without tests for me equals "proof of concept" quality level and I'm happy the policy around here is no-tests, no-merge! :) More on topic: thanks for having come up with a fix for this!! 😄 🎆 👍 👏 |
@quasipedia I totally agree with you. The problem is the tile_maps widget (which I didn't author but which I intend to contribute to) lacks any automated tests. I'd be happy to add a test for my added feature if there was any test suite already in place. |
I'd love this feature. I wonder how long it takes to appear in Found once pulled. |
I'm super surprised this is still an issue, would be great to get it resolved. @jmleoni Is the automated test for the tile maps widget still an issue? |
@berglh At the time I was asked by the kibana team to write an automated test, there weren't any for the map widgets. Now automated tests are implemented but I never had the leisure to spend a couple of hours on issue an updated PR with my fix on master. |
@thomasneirynck I believe this is the functionality I was looking for in our slack discussion. This feature would be particularly useful for reporting. |
We are working on a new implementation of map visualizations and are not planning to add any new features to the existing implementation. We will take this suggestion under consideration for the new app. |
+1 |
Pinging @elastic/kibana-app |
Closing this as dupe of #53831. This enhancement would be added to the Maps-app, and not the coordinate map visualization. |
It would be awesome to have a new settings for the tile maps panel which auto fit the map to data bounds.
When I create a tile maps and split the map based on a terms aggregation, each time I reopen the dashboard, each map is using the "first map settings" to display data.
As I am aggregating by country code, I have to click on the auto fit button on each map. Here is the automatic rendering I'd like to have.
The text was updated successfully, but these errors were encountered: