Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Reduce page rendering cycles and api calls #66216

Merged
merged 10 commits into from
May 19, 2020
Merged

[Uptime] Reduce page rendering cycles and api calls #66216

merged 10 commits into from
May 19, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented May 12, 2020 •
edited
Loading

Summary

Fixes elastic/uptime#196

Following changes are done in this PR

  • Made sure API's are called only once on refresh and reload.
  • Reduced rendered from 6 to 3
  • Page load better and looks crispy while reloading.
  • Also moved refresh logic to context to keep it in one place.
  • Load index pattern only once in a session

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 requested a review from justinkambic May 13, 2020 23:23
@shahzad31 shahzad31 marked this pull request as ready for review May 13, 2020 23:23
@shahzad31 shahzad31 requested a review from a team as a code owner May 13, 2020 23:23
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels May 13, 2020
@shahzad31 shahzad31 requested a review from andrewvc May 14, 2020 15:40
@shahzad31 shahzad31 mentioned this pull request May 18, 2020
Closed
justinkambic
justinkambic approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great cleanup/refactoring here!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit e584647 into elastic:master May 19, 2020
@shahzad31 shahzad31 deleted the optimize-api-calls branch May 19, 2020 10:44
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 19, 2020
@shahzad31
[Uptime] Reduce page rendering cycles and api calls (elastic#66216)
9f2cbcc
@shahzad31 shahzad31 mentioned this pull request May 19, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 19, 2020
@shahzad31
[Uptime] Reduce page rendering cycles and api calls (elastic#66216)
e8c1288
@shahzad31 shahzad31 mentioned this pull request May 19, 2020
Merged
shahzad31 added a commit that referenced this pull request May 19, 2020
@shahzad31
[7.x] [Uptime] Reduce page rendering cycles and api calls (#66216) (#…
010b8ea 
…66997)
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 20, 2020
shahzad31 added a commit that referenced this pull request May 21, 2020
@shahzad31
[7.8] [Uptime] Reduce page rendering cycles and api calls (#66216) (#…
dff4ed8 
…66998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate Rendering cycles in Uptime Overview page
4 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic