Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor List can say "no monitors found" while still loading #207

Closed
justinkambic opened this issue May 18, 2020 · 3 comments · Fixed by elastic/kibana#67378
Closed

Monitor List can say "no monitors found" while still loading #207

justinkambic opened this issue May 18, 2020 · 3 comments · Fixed by elastic/kibana#67378
Assignees
Labels
bug Something isn't working good first issue Good for newcomers v7.8.0

Comments

@justinkambic
Copy link

Describe the bug
We should check if the Monitor List component is still awaiting a server response before allowing the table's noItemsMessage to be "No uptime monitors found". If the query takes a long time (this happens to me when I put 100 items on the page at once), it will say there weren't any found and a couple of seconds later display the items.

To Reproduce
Steps to reproduce the behavior:

  1. Configure 2+ heartbeat instances to watch 100+ monitors
  2. Set the Monitor List's size to 100
  3. Use the Uptime app's date picker refresh button
  4. Observe the message shown in the table

Expected behavior
We want this message to indicate that the list is loading. This will require the creation of a new message to display in the translations folder.

May-18-2020 16-14-19

There are cases where loading === true and we display a non-loading message:

image

@justinkambic justinkambic added bug Something isn't working good first issue Good for newcomers labels May 18, 2020
@shahzad31
Copy link

i suspect this will be resolved once we merge elastic/kibana#66216

@justinkambic
Copy link
Author

I'm about to review that, so if it's no longer an issue I'll add resolves keywords to that PR.

@shahzad31
Copy link

i believe this has been fixed in elastic/kibana#66216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers v7.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants