-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Typescript index pattern field editor / Expression functions for bucket agg #65254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes here LGTM; thanks for the cleanup! 🙏
…for bucket agg (elastic#65254) # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # src/legacy/ui/public/field_editor/field_editor.test.tsx # src/plugins/data/public/index.ts # src/plugins/data/public/public.api.md
* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...
…for bucket agg (#65254) (#65281) # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # src/legacy/ui/public/field_editor/field_editor.test.tsx # src/plugins/data/public/index.ts # src/plugins/data/public/public.api.md Co-authored-by: Elastic Machine <[email protected]>
Summary
Code cleanup:
https://github.com/elastic/kibana/pull/63495/files#diff-74da9568fc89aa298ec74d05d6fd8a4c
customLabel
fromFilters
expression functions for bucket agg