Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Typescript index pattern field editor / Expression functions for bucket agg #65254

Merged
merged 1 commit into from
May 5, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 5, 2020

Summary

Code cleanup:

@alexwizp alexwizp marked this pull request as ready for review May 5, 2020 13:05
@alexwizp alexwizp requested a review from a team as a code owner May 5, 2020 13:05
@alexwizp alexwizp self-assigned this May 5, 2020
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label May 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes here LGTM; thanks for the cleanup! 🙏

@alexwizp alexwizp merged commit 5967f4e into elastic:master May 5, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request May 5, 2020
…for bucket agg (elastic#65254)

# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
#	src/legacy/ui/public/field_editor/field_editor.test.tsx
#	src/plugins/data/public/index.ts
#	src/plugins/data/public/public.api.md
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 5, 2020
* master: (133 commits)
  Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254)
  Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848)
  Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986)
  [SIEM] Removes prebuilt rules number dependency (elastic#65128)
  [Maps] add categorical palettes with 20 and 30 categories (elastic#64701)
  [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724)
  [Uptime] Console errors in case index missing (elastic#65115)
  [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412)
  [test/functional] Tsfy page objects (elastic#64887)
  [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195)
  [Maps] Add global fit to data (elastic#64702)
  Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699)
  [SIEM] [Cases] External service selection per case (elastic#64775)
  [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055)
  [Metrics UI] Remove APM Hard Dependency (elastic#64952)
  [Ingest] Datastream list: add icons and dashboard links (elastic#65048)
  disable plugins. they could access ES via SO repository (elastic#65242)
  Feature fleet enrollment instructions (elastic#65176)
  [SIEM] Adds 'Configure connector' Cypress test (elastic#64807)
  [TSVB] Fix std deviation band mode (elastic#64413)
  ...
alexwizp added a commit that referenced this pull request May 5, 2020
…for bucket agg (#65254) (#65281)

# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
#	src/legacy/ui/public/field_editor/field_editor.test.tsx
#	src/plugins/data/public/index.ts
#	src/plugins/data/public/public.api.md

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants