[Maps] add categorical palettes with 20 and 30 categories #64701
Conversation
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
| @@ -260,33 +260,40 @@ export class BlendedVectorLayer extends VectorLayer implements IVectorLayer { | |||
| prevDataRequest: this.getDataRequest(dataRequestId), | |||
| nextMeta: searchFilters, | |||
| }); | |||
| if (canSkipFetch) { | |||
There was a problem hiding this comment.
This PR highlighted an error with blended vector layers that super._syncData is skipped when new source data is not needed. Skipping super._syncData could prevent style meta changes from gettin picked up and re-synced.
|
tested for both fill and border color palettes
This makes it more evident that legends by the same field should show different properties together to avoid legends that tall and with so much white space. This rings a bell of an issue, but I haven't found it, should I create it? |
I don't think an issue ever got created. Please create one |
Thanks, I will put this on hold since the example I used was rather stupid since I could simply put a zero width 🙃, and I can't find another good use case for that situation. The other variable I think would fit in this case is shape, but still not really clear to me. Sorry for the noise. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
This is great! It allows for much more colorful and informative maps. Functionally it expands the utility of maps and code-wise, it looks really good. The one issue I have is the same one cited above by @jsanz with the height of the legend. It's hard for me to consider this a separate issue though. I understand you could argue this issue always existed, but having this many categories hits a tipping point where it seems like there should be an accompanying solution possibly in the form of some combination of the following (apologies if I'm missing any history on any of these):
I also understand we're trying to squeeze a lot in what is both a legend and an interactive control interface which I think is why this is getting harder. |
There was a problem hiding this comment.
From a functional point of view, I don't see any issues with adding these two new categorical palettes. Tested locally on Firefox and Chromium.
I have a couple of comments about the Other category, but since it applies to all palettes I will put them into a new request.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@aaronjcaldwell we already offer scrolling for large legends, limiting further the height feels too complex for the user. A different approach for categorical maps may be worth exploring, something like what we have in visualize where by default legend is set up on the right, so vertical layout as we do, but it's also possible to put them on top or the bottom of the panel, so horizontal layout. We could have a setting in the layer for allowing the legend to have multiple columns, or just to flow horizontally as in our other charts. Also as you mention, maybe we could combine different variables horizontally, but maybe that could be confusing, I'd need to see this in a mockup or something. The vertical layout for different variables seems to work pretty well to me, even we could maybe improve the layout a bit. In the following gif I show a layer with all variables activated, it's impossible to say to which variable they apply, right?
|
Allowing for more categories is value added and the legend does scroll when the page height is reached. Any problems with merging this as is? |
There was a problem hiding this comment.
@jsanz @nreese I'm sorry, the scrolling suggestion wasn't very specific. I understand the current vertical scrolling behavior, I was referring to some way of limiting the size of the container containing the labels specifically to something scrollable. I'm not 100% sold on that solution either (no one likes scrollable containers in scrollable containers) but mostly just spitballing ideas.
No objections to merging.
) * [Maps] add categorical palettes with 20 and 30 categories * fix ts-lint Co-authored-by: Elastic Machine <[email protected]>
…65275) * [Maps] add categorical palettes with 20 and 30 categories * fix ts-lint Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...
This PR updates categorical palettes with additional palettes. One has 20 categories and the other has 30 categories. This will help users with higher cardinality fields.