Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix flaky test by closing options after use #64714

Merged
merged 2 commits into from
Apr 29, 2020
Merged

[Lens] Fix flaky test by closing options after use #64714

merged 2 commits into from
Apr 29, 2020

Conversation

wylieconlon
Copy link
Contributor

Fixes flakiness found by @spalger and @restrry in #64685 and #64414

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.8.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

spalger
spalger approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit af2e86f into elastic:master Apr 29, 2020
@wylieconlon wylieconlon deleted the lens/fix-flaky-test branch April 29, 2020 14:50
@wylieconlon wylieconlon mentioned this pull request Apr 29, 2020
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Apr 29, 2020
@elasticmachine @wylieconlon
[Lens] Fix flaky test by closing options after use (elastic#64714)
95baf31 
Co-authored-by: Elastic Machine <[email protected]>
wylieconlon pushed a commit that referenced this pull request Apr 29, 2020
@elasticmachine
[Lens] Fix flaky test by closing options after use (#64714) (#64782)
874eefe 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@spalger spalger spalger approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wylieconlon @elasticmachine @kibanamachine @spalger @mbondyra