[Lens] Fix flaky test by closing options after use

elastic · Apr 28, 2020 · 8b51401 · 8b51401
1 parent 7dc3972
commit 8b51401
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts
@@ -12,6 +12,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
   const testSubjects = getService('testSubjects');
   const retry = getService('retry');
   const find = getService('find');
+  const comboBox = getService('comboBox');
   const PageObjects = getPageObjects([
     'header',
     'common',
@@ -107,20 +108,17 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
      * @param opts.operation - the desired operation ID for the dimension
      * @param opts.field - the desired field for the dimension
      */
-    async configureDimension(opts: { dimension: string; operation?: string; field?: string }) {
+    async configureDimension(opts: { dimension: string; operation: string; field: string }) {
       await find.clickByCssSelector(opts.dimension);
 
-      if (opts.operation) {
-        await find.clickByCssSelector(
-          `[data-test-subj="lns-indexPatternDimensionIncompatible-${opts.operation}"],
-           [data-test-subj="lns-indexPatternDimension-${opts.operation}"]`
-        );
-      }
+      await find.clickByCssSelector(
+        `[data-test-subj="lns-indexPatternDimensionIncompatible-${opts.operation}"],
+          [data-test-subj="lns-indexPatternDimension-${opts.operation}"]`
+      );
 
-      if (opts.field) {
-        await testSubjects.click('indexPattern-dimension-field');
-        await testSubjects.click(`lns-fieldOption-${opts.field}`);
-      }
+      const target = await testSubjects.find('indexPattern-dimension-field');
+      await comboBox.openOptionsList(target);
+      await comboBox.setElement(target, opts.field);
     },
 
     /**