Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cypress dev-dependency from 4.2.0 to 4.4.1 #64408

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Bump cypress dev-dependency from 4.2.0 to 4.4.1 #64408

merged 4 commits into from
Apr 27, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Apr 24, 2020

No description provided.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 24, 2020
@watson watson self-assigned this Apr 24, 2020
@watson watson marked this pull request as ready for review April 24, 2020 13:39
@watson watson requested a review from a team as a code owner April 24, 2020 13:39
spalger
spalger approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm definitely wondering why there are two random (though seemingly fine) changes added in here as well...

@watson
Copy link
Contributor Author

watson commented Apr 27, 2020 •
edited
Loading

@spalger The reason for the type changes is that the scripts/type_check script started complaining after I upgraded the cypress module. There were two issues:

  1. It didn't like that there were multiple different versions of @types/chai in our dependency tree, so I had to use yarn resolutions to bring them all in line.
  2. It suddenly didn't understand that fromNode returned an fs.Stats type object (it was unknown), so I had to hardcode the type for it to be happy. Personally I don't like this fix as I don't know why it suddenly wasn't happy when it was before, but I checked the code and I can't see how this cannot be of type fs.Stats, so it should be safe to do so - though I never like changes like this which I can't explain.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit 8c05a72 into elastic:master Apr 27, 2020
@watson watson deleted the bump-cypress branch April 27, 2020 12:23
watson added a commit to watson/kibana that referenced this pull request Apr 27, 2020
@watson
Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
9d74abd
@watson watson mentioned this pull request Apr 27, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 27, 2020
@gmmorris
Merge branch 'master' into alerting/np-migration
3d91286 
* master: (78 commits)
  Remove SO root property index signature (elastic#64434)
  [ML] Functional tests - stabilize job row details validations (elastic#64503)
  [Ingest] Add Global settings flyout (elastic#64276)
  Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
  Migrate saved object of type url to kibana platform (elastic#64043)
  [NP] Migrate ui capabilities (elastic#64185)
  Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407)
  Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149)
  Remove SO autocreateindex error and error page (elastic#64037)
  Fix issue with yarn.lock (elastic#64496)
  Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433)
  Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401)
  Bump karma dev-dependency from 3.1.4 to 5.0.2 (elastic#64403)
  Bump iedriver dev-dependency from 3.14.1 to 3.14.2 (elastic#64406)
  Revert "disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)"
  Revert "skip flaky suite (elastic#64310)"
  skip flaky suite (elastic#64310)
  disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)
  [Maps] Include maps styles in embeddables factory so that they're bundled w/ consuming plugins (elastic#64460)
  update charts library to 18.4.2 (elastic#64438)
  ...
watson added a commit that referenced this pull request Apr 27, 2020
@watson
Bump cypress dev-dependency from 4.2.0 to 4.4.1 (#64408) (#64512)
0e99bd6
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 28, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
6c71bff 
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (152 commits)
  [Ingest pipelines] Simulate pipeline (elastic#64223)
  Ability to get scoped call cluster from alerting and action executors (elastic#64432)
  Add editApp and editPath to embeddable (elastic#64297)
  TSVB validation: Allow numeric values for axes (elastic#63553)
  [ML] Fixing optional plugin dependency types (elastic#64450)
  [Logs UI] Alerting (elastic#62806)
  [Endpoint] Show Policy Status on Host Details using Policy Response API (elastic#64116)
  [Maps] update LayerWizard previewLayer to take layerDescriptor instead of ISource (elastic#64461)
  Remove SO root property index signature (elastic#64434)
  [ML] Functional tests - stabilize job row details validations (elastic#64503)
  [Ingest] Add Global settings flyout (elastic#64276)
  Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
  Migrate saved object of type url to kibana platform (elastic#64043)
  [NP] Migrate ui capabilities (elastic#64185)
  Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407)
  Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149)
  Remove SO autocreateindex error and error page (elastic#64037)
  Fix issue with yarn.lock (elastic#64496)
  Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433)
  Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@watson watson

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watson @kibanamachine @spalger