Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Integration Tests.src/core/public/application/integration_tests - AppContainer can navigate between two applications with custom appRoutes #64381

Closed
kibanamachine opened this issue Apr 23, 2020 · 16 comments · Fixed by #64487
Closed

Failing test: Jest Integration Tests.src/core/public/application/integration_tests - AppContainer can navigate between two applications with custom appRoutes #64381

kibanamachine opened this issue Apr 23, 2020 · 16 comments · Fixed by #64487
Assignees
@joshdover
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 23, 2020 •
edited
Loading

A test failed on a tracked branch

Error: Caught error after test environment was torn down

Http server is not setup up yet
    at HttpServer.start (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/src/core/server/http/http_server.ts:117:13)
    at HttpService.start (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/src/core/server/http/http_service.ts:110:29)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@spalger spalger added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf
Copy link
Contributor

rudolf commented Apr 24, 2020 

[2020-04-23T23:14:51.247Z]  FAIL  src/core/public/application/integration_tests/router.test.tsx
[2020-04-23T23:14:51.247Z]   ● AppContainer › can navigate between two applications with custom appRoutes
[2020-04-23T23:14:51.247Z] 
[2020-04-23T23:14:51.247Z]     Caught error after test environment was torn down
[2020-04-23T23:14:51.247Z] 
[2020-04-23T23:14:51.247Z]     Http server is not setup up yet
[2020-04-23T23:14:51.247Z] 
[2020-04-23T23:14:51.247Z]       115 |       registerStaticDir: this.registerStaticDir.bind(this),
[2020-04-23T23:14:51.247Z]       116 |       registerOnPreAuth: this.registerOnPreAuth.bind(this),
[2020-04-23T23:14:51.247Z]     > 117 |       registerOnPostAuth: this.registerOnPostAuth.bind(this),
[2020-04-23T23:14:51.247Z]           |             ^
[2020-04-23T23:14:51.247Z]       118 |       registerOnPreResponse: this.registerOnPreResponse.bind(this),
[2020-04-23T23:14:51.247Z]       119 |       createCookieSessionStorageFactory: <T>(cookieOptions: SessionStorageCookieOptions<T>) =>
[2020-04-23T23:14:51.247Z]       120 |         this.createCookieSessionStorageFactory(cookieOptions, config.basePath),
[2020-04-23T23:14:51.247Z] 
[2020-04-23T23:14:51.247Z]       at HttpServer.start (src/core/server/http/http_server.ts:117:13)
[2020-04-23T23:14:51.247Z]       at HttpService.start (src/core/server/http/http_service.ts:110:29)

Seems like a race condition between registerStaticDir and stopping the HttpServer where we set this.server = undefined I think we can just remove that line

kibana/src/core/server/http/http_server.ts

Line 198 in ab39ceb

this.server = undefined;

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Apr 25, 2020
@spalger
disable flaky suite (#64382) (#64381) (#64480)
387c581
spalger added a commit that referenced this issue Apr 25, 2020
@spalger
disable flaky suite (#64382) (#64381) (#64480)
65384d4 
(cherry picked from commit 387c581)
@spalger
Copy link
Contributor

spalger commented Apr 25, 2020

Skipped

master: 387c581
7.x/7.8: 65384d4

spalger added a commit that referenced this issue Apr 26, 2020
@spalger
Revert "disable flaky suite (#64382) (#64381) (#64480)"
ac2c239 
This reverts commit 387c581.
spalger added a commit that referenced this issue Apr 26, 2020
@spalger
Revert "disable flaky suite (#64382) (#64381) (#64480)"
b489ec4 
This reverts commit 65384d4.
This was referenced Apr 26, 2020
Closed
Closed
Closed
@spalger
Copy link
Contributor

spalger commented Apr 26, 2020

Unskipped this test because it was causing the following failures:

@joshdover joshdover mentioned this issue Apr 26, 2020
Merged
7 tasks
@joshdover joshdover self-assigned this Apr 26, 2020
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

gmmorris added a commit to gmmorris/kibana that referenced this issue Apr 27, 2020
@gmmorris
Merge branch 'master' into alerting/np-migration
3d91286 
* master: (78 commits)
  Remove SO root property index signature (elastic#64434)
  [ML] Functional tests - stabilize job row details validations (elastic#64503)
  [Ingest] Add Global settings flyout (elastic#64276)
  Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
  Migrate saved object of type url to kibana platform (elastic#64043)
  [NP] Migrate ui capabilities (elastic#64185)
  Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407)
  Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149)
  Remove SO autocreateindex error and error page (elastic#64037)
  Fix issue with yarn.lock (elastic#64496)
  Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433)
  Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401)
  Bump karma dev-dependency from 3.1.4 to 5.0.2 (elastic#64403)
  Bump iedriver dev-dependency from 3.14.1 to 3.14.2 (elastic#64406)
  Revert "disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)"
  Revert "skip flaky suite (elastic#64310)"
  skip flaky suite (elastic#64310)
  disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)
  [Maps] Include maps styles in embeddables factory so that they're bundled w/ consuming plugins (elastic#64460)
  update charts library to 18.4.2 (elastic#64438)
  ...
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger spalger removed the blocker label Apr 30, 2020
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine kibanamachine reopened this May 1, 2020
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@rudolf
Copy link
Contributor

rudolf commented May 12, 2020

Closing as there has been no failures in 11 days. Seems like the last failure might have been an old branch that didn't have the fix merged in yet.

@rudolf rudolf closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdover joshdover

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid race condition between HttpServer.stop() and HttpServerSetup methods joshdover/kibana
5 participants
@rudolf @spalger @joshdover @elasticmachine @kibanamachine