Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React component support fork 2 #64224

Closed
wants to merge 19 commits into from
Closed

React component support fork 2 #64224

wants to merge 19 commits into from

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Apr 22, 2020 •
edited
Loading

Summary

Partially addresses #59744

This PR moves ExpressionRenderHandler (renamed to ExpressionRendering) into expressions services. This will enable subsequently to move expressions React component and ExpressionLoader to the expression service, too.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@streamich streamich requested a review from a team as a code owner April 22, 2020 18:29
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Apr 22, 2020
@streamich streamich added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review Team:AppArch v7.8.0 v8.0.0 labels Apr 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich requested a review from ppisljar April 22, 2020 19:00
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@ppisljar
Copy link
Member

@elasticmachine merge upstream

@streamich streamich added v7.9.0 and removed v7.8.0 labels Apr 28, 2020
@ppisljar
Copy link
Member

please provide description and link to an issue. why not move the ExpressionRendering inside expression service with this PR already, seems it should be a simple change from here on ?

@streamich streamich added the WIP Work in progress label May 1, 2020
@streamich
Copy link
Contributor Author

streamich commented May 1, 2020 •
edited
Loading

... why not move the ExpressionRendering inside expression service with this PR already, seems it should be a simple change from here on ?

@ppisljar it is what this PR does, it moves ExpressionRendring inside the expression service 😄

@streamich streamich removed the review label May 1, 2020
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar
ppisljar approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@spalger spalger added v7.9.2 and removed v7.9.0 labels Sep 3, 2020
@stacey-gammon
Copy link
Contributor

Can this be closed? looks stale? I'm going to remove 7.9.2 label on it anyhow.

@streamich streamich closed this by deleting the head repository Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@streamich @elasticmachine @ppisljar @kibanamachine @stacey-gammon @spalger