Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass data to expression renderers #64420

Closed
3 tasks done
Tracked by #46909
streamich opened this issue Apr 24, 2020 · 2 comments
Closed
3 tasks done
Tracked by #46909

Add ability to pass data to expression renderers #64420

streamich opened this issue Apr 24, 2020 · 2 comments
Assignees
@streamich
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) technical debt Improvement of the software architecture and operational architecture

Comments

@streamich
Copy link
Contributor

streamich commented Apr 24, 2020 •
edited
Loading

expressions plugin has special handling for uiState and it has TypeScript type any. expressions plugin should not explicitly know about uiState and have good TypeScript typing for extra data passed to expression renderers.

  • Add mechanism to allow expression users to pass extra parameters to expression renderer.
  • Remove special handling for uiState.
  • User should be able to provide type of parameters they pass to expression renderer. The value is typed to object and user should cast it to the correct type.

Parent issue: #46909
@streamich streamich mentioned this issue Apr 24, 2020
Closed
20 tasks
@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch technical debt Improvement of the software architecture and operational architecture labels Apr 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Apr 24, 2020
Closed
2 tasks
@streamich streamich changed the title Remove uiState from Expressions plugin Add ability to pass data to expression renderers Nov 12, 2020
@streamich streamich self-assigned this Nov 12, 2020
@streamich streamich mentioned this issue Nov 12, 2020
Closed
8 tasks
@streamich
Copy link
Contributor Author

Decided to park this issue until there is a good use case. Initial implementation can be found here: #83315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expression renderer data
2 participants
@streamich @elasticmachine