-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing multiple metrics #62929
fixing multiple metrics #62929
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
64066a9
to
377627e
Compare
Tested and visualizations with more complex metrics and axes configurations render fine again. Could you elaborate on how this fix works? It seems like this broke because something generic (in how state management works, it seems) got changed, but the fix only addresses a single local instance. Is it because this is happening in a special tab? |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
vis.setState was updated to allow changing type (where before if you changed type it would actually just change the .type property it would now really recreate that type (get the type def from registry, init default parameters etc). so when changing type default parameters got applied as nothing else got passed in. We are now passing whole state in and just updating the type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @ppisljar tested and works as expected. A quick code search didn't show any other places where setState
was called the wrong way.
Summary
resolves #62771
Checklist
Delete any items that are not applicable to this PR.
For maintainers