fixing multiple metrics (#62929) (#62961)

elastic · Apr 9, 2020 · 9aa599c · 9aa599c
1 parent 9645f6f
commit 9aa599c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.../vis_type_vislib/public/components/options/metrics_axes/__snapshots__/index.test.tsx.snap b/.../vis_type_vislib/public/components/options/metrics_axes/__snapshots__/index.test.tsx.snap
diff --git a/...legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.test.tsx b/...legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.test.tsx
@@ -95,6 +95,7 @@ describe('MetricsAxisOptions component', () => {
           schemas: { metrics: [{ name: 'metric' }] },
         },
         setState: jest.fn(),
+        serialize: jest.fn(),
       },
       stateParams: {
         valueAxes: [axis],

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx
@@ -299,7 +299,7 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
   }, [stateParams.seriesParams]);
 
   useEffect(() => {
-    vis.setState({ type: visType } as any);
+    vis.setState({ ...vis.serialize(), type: visType });
   }, [vis, visType]);
 
   return isTabSelected ? (