[APM] Service map - fixes irrelevant services on data refresh #62750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he API response.
ogupte
added
release_note:skip
dgieselaar
approved these changes
Apr 7, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
Apr 7, 2020
…c#62750) Co-authored-by: Elastic Machine <[email protected]>
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
Apr 7, 2020
…c#62750) Co-authored-by: Elastic Machine <[email protected]>
smith
reviewed
Apr 7, 2020
| @@ -124,6 +124,12 @@ export function Cytoscape({ | |||
| // Trigger a custom "data" event when data changes | |||
| useEffect(() => { | |||
| if (cy && elements.length > 0) { | |||
| const renderedElements = cy.elements('node,edge'); | |||
There was a problem hiding this comment.
What does the ('node', 'edge') do here?
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742) [Remote Clusters] Update callout and move server_name field (elastic#62352) Removes Pitch Presentation Template from Canvas (elastic#62688) FTR: Enable w3c for chromedriver (elastic#62542) [ML] Disable functional tests [ILM] Skip failing API integration test (elastic#62779) [SIEM] Update beat doc (elastic#61902) [Search] Properly add slash preceding path in async search (elastic#62722) [APM] make sure environment query is correct for service maps… (elastic#62764) Add service map icon for rum-js agent type (elastic#62721) [APM] Service map - fixes irrelevant services on data refresh (elastic#62750) [APM] Service map - Fix taxi edge arrow orientation (elastic#62741) [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754) [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059) [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
|
Tests ok: |
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62749 by removing rendered nodes which are absent in the API response.