Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Change custom link from EuiListGroupItem to EuiLink #62742

Merged
merged 1 commit into from
Apr 7, 2020
Merged

[APM] Change custom link from EuiListGroupItem to EuiLink #62742

merged 1 commit into from
Apr 7, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #62655

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Feature:Custom Links labels Apr 7, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 7, 2020 08:29
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #39180 failed 8389c4dc7a2f27755e4821821345def1faeeb787

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar
dgieselaar reviewed Apr 7, 2020
View reviewed changes
.../plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkSection.tsx
@@ -19,7 +31,7 @@ export const CustomLinkSection = ({
customLinks: CustomLink[];
transaction: Transaction;
}) => (
<SectionLinks>
<ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change not be made in the shared SectionLinks component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agreed, but due to the deadline of the release I thought to do it here, and create a new issue to replace it later on SectionLinks, WDYT?

dgieselaar
dgieselaar approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a question, but other than that looks good.

@dgieselaar
Copy link
Member

dgieselaar commented Apr 7, 2020 via email

@cauemarcondes
Copy link
Contributor Author

Sounds good to me, might want to raise that in the observability group in
case it's an issue for them as well.

I can do it, but the reason why I moved to EuiLink was because of external links. They only use it to internal links

@cauemarcondes cauemarcondes merged commit d707184 into elastic:master Apr 7, 2020
@cauemarcondes cauemarcondes deleted the custom-link-62655 branch April 7, 2020 16:39
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
@cauemarcondes
[APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742
be81408 
)
@cauemarcondes cauemarcondes mentioned this pull request Apr 7, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
@cauemarcondes
[APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742
f848fff 
)
@cauemarcondes cauemarcondes mentioned this pull request Apr 7, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 7, 2020
@gmmorris
Merge branch 'master' into alerting/tls-disable
184fde1 
* master:
  [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742)
  [Remote Clusters] Update callout and move server_name field (elastic#62352)
  Removes Pitch Presentation Template from Canvas (elastic#62688)
  FTR: Enable w3c for chromedriver (elastic#62542)
  [ML] Disable functional tests
  [ILM] Skip failing API integration test (elastic#62779)
  [SIEM] Update beat doc (elastic#61902)
  [Search] Properly add slash preceding path in async search (elastic#62722)
  [APM] make sure environment query is correct for service maps… (elastic#62764)
  Add service map icon for rum-js agent type (elastic#62721)
  [APM] Service map - fixes irrelevant services on data refresh (elastic#62750)
  [APM] Service map - Fix taxi edge arrow orientation (elastic#62741)
  [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754)
  [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059)
  [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
cauemarcondes added a commit that referenced this pull request Apr 7, 2020
@cauemarcondes
[APM] Change custom link from EuiListGroupItem to EuiLink (#62742) (#…
7acea13 
…62830)
cauemarcondes added a commit that referenced this pull request Apr 7, 2020
@cauemarcondes
[APM] Change custom link from EuiListGroupItem to EuiLink (#62742) (#…
5cd42cb 
…62829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
Feature:Custom Links release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Change custom link from EuiListGroupItem to EuiLink
3 participants
@cauemarcondes @kibanamachine @dgieselaar