Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/nav details #6170

Merged
merged 27 commits into from
Feb 10, 2016
Merged

Fix/nav details #6170

merged 27 commits into from
Feb 10, 2016

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented Feb 9, 2016

alignedright

  • Implements new icons for Discover/Visualize/Dashboard
  • Brings in @spalger's pull for plugins exporting links
  • Changed the logo svg to be inkscape compatible and added some padding
  • Added the drop shadow from the app container
  • Added a hover when mousing over app
  • Vertically centered icons, left justified links
  • Reduced width of sidebar to 160px

Continuation of #6157.

spalger and others added 25 commits January 25, 2016 19:23
@spalger
[uiExports][chrome] support uiExports.links
72ef16f
@spalger
[tabs] persist last urls to sessionStorage
517bf71
@spalger
[appSwitcher] allow hash-based navigation by default, disable on stat…
6892bfa 
…us page
@spalger
[appSwitcher] when tabs match links, use their last Url
1f372bf
@spalger
[chrome] fix broken test
0b56954
@spalger
Merge branch 'master' into implement/exportLinks
90977e6
@spalger
[chrome/tab] ignore lastUrls that have different basePaths
f5ff46a
@spalger
[chrome/Tab] fix tests
8f4b48f
@spalger
Merge branch 'master' into implement/exportLinks
775812a
@spalger
[appSwitcher] es6-ify
eef94c7
@spalger
[chrome/api/apps] use path getter rather than multiple checks
5de1094
@spalger
[ui/UiApp] dress like a cool kid
b5ca051
@spalger
[ui/uiNav*] es6-ify
bc4dce1
@simianhacker
Merge branch 'design' into implement/exportLinks
f2c85d9
Change svg to be inkscape compatible
a75df51
Add padding around logo
0a1b516
Add drop shadow, hover effect, center icons vertically
3abd125
Move logo text up. Reduce width of sidebar to 160px
e106eb9
@simianhacker
Adding svgs and CSS for nav
d831293
Fix merge
f9d9beb
Add flex container inside app-wrapper, attach shadow to that
3100a2f
Fix icons in firefox
e7c98c0
@panda01
[Icons] vertically aligned the icons
4dbba2f
@panda01
Merge remote-tracking branch 'upstream/feature/design' into fix/nav-d…
b2e0ff1 
…etails
@panda01
[Tests] Updated the tests with thte proper selector
5b1576f
@simianhacker
Copy link
Member

image

When you switch to a plugin the Kibana logo is missing. I believe in previous version that was set dynamically via branding but it needs to be static.

@panda01 panda01 force-pushed the fix/nav-details branch 2 times, most recently from d3ef5fe to 6afcb8c Compare February 10, 2016 17:40
@rashidkpc
Copy link
Contributor

jenkins, test it

panda01 added a commit that referenced this pull request Feb 10, 2016
@panda01
Merge pull request #6170 from panda01/fix/nav-details
af5f0b6 
Fix/nav details
@panda01 panda01 merged commit af5f0b6 into elastic:feature/design Feb 10, 2016
@rashidkpc
Copy link
Contributor

@simianhacker and I have both looked at this, merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panda01 @simianhacker @rashidkpc @spalger