Nav bar tweaks #6157
Closed
Nav bar tweaks #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rashidkpc
commented
Feb 8, 2016
rashidkpc
commented
- Implements new icons for Discover/Visualize/Dashboard
- Brings in @spalger's pull for plugins exporting links
- Changed the logo svg to be inkscape compatible and added some padding
- Added the drop shadow from the app container
- Added a hover when mousing over app
- Vertically centered icons, left justified links
- Reduced width of sidebar to 160px
|
This has a bug, the
|
|
could we increase vertical spacing between icons? example: |
| @@ -9,8 +9,8 @@ | |||
| ng-href="{{ link.active ? link.url : (link.lastSubUrl || link.url) }}" | |||
| data-test-subj="appLink"> | |||
|
|
|||
| <div ng-if="link.icon" ng-style="{ 'background-image': 'url(../' + link.icon + ')' }" class="app-icon"></div> | |||
| <div ng-if="!link.icon" class="app-icon app-icon-missing">{{ link.title[0] }}</div> | |||
| <div ng-if="link.icon" ng-style="{ 'mask-image': 'url(../' + link.icon + ')' }" class="app-icon"></div> | |||
There was a problem hiding this comment.
Weren't we going to use just an img tag for this?
There was a problem hiding this comment.
I have no strong opinion on this. From a user standpoint it works the same. @simianhacker any reason you went this direction?
|
jenkins, test it |
rashidkpc
force-pushed
the
fix/nav-details
branch
from
9783f01 to
3100a2f
Compare
Merged
|
Continuing this in the pr above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.