[SIEM] Add developer optimization scripts for their environments #61337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
the
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
spong
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Checked out, ran node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig to optimize tsconfigs, and verified the following:
- IDE (Webstorm) linting functioned as expected
- Verified type-checking improvements (
1m40sfor optimized vs2m23sfor un-optimized) - Ran full
start-test-allwithout error15m38s(includes gql-type-gen, type-checking, linting, i18n-check, circ-deps-check, and running all jest tests) - Re-launched IDE and functionality was as expected (and felt a bit snappier in navigating usages/adding imports).
LGTM! 👍 Thanks for the dev improvements here @FrankHassanabad, greatly appreciated! 🎉
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an optimization script very copied and slightly modified from:
Usage:
Run this to do an dev tsconfig optimization:
Run this to undo the optimization:
Testing and what this does:
Run this:
Then run your start-test-all or at least your linter, typescript check, and jest tests to make sure they all operate as expected. Restart your IDE and ensure everything works as expected.
Run
git statusand ensure it looks like no new files want to be checked in.Open up your:
And notice it is now changed when optimization has run to use a smaller set of includes.
Open up your:
And notice it is now changed when optimization is run to use a smaller set of includes.