[APM] Script optimization of APM-specific tsconfig #49868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
|
|
Looks great to me! I wonder if there's a benchmark we can run to compare the performance. |
|
You can trace the logs from
vs
|
smith
approved these changes
Oct 31, 2019
dgieselaar
added
apm-test-plan-7.5.0
release_note:skip
|
Maybe it’s just me but can you elaborate on the |
|
Oh, it looks like Can you then document the scripts in the readme (and PR description), and how they should be invoked? |
sorenlouv
approved these changes
Nov 1, 2019
|
The optimization breaks the bootstrapping process (which uses |
dgieselaar
force-pushed
the
apm-optimize-tsconfig
branch
from
0c4b867 to
a5e632c
Compare
💚 Build Succeeded
|
dgieselaar
force-pushed
the
apm-optimize-tsconfig
branch
from
a5e632c to
998b5af
Compare
💚 Build Succeeded
|
dgieselaar
force-pushed
the
apm-optimize-tsconfig
branch
from
ba71a99 to
03753ce
Compare
💔 Build Failed
|
dgieselaar
force-pushed
the
apm-optimize-tsconfig
branch
from
03753ce to
b093695
Compare
dgieselaar
force-pushed
the
apm-optimize-tsconfig
branch
from
b093695 to
42287ea
Compare
💔 Build Failed
|
💚 Build Succeeded |
This was referenced Nov 11, 2019
FrankHassanabad
added a commit
that referenced
this pull request
Mar 25, 2020
## Summary This adds an optimization script very copied and slightly modified from: * #49868 Usage: Run this to do an dev tsconfig optimization: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Run this to undo the optimization: ```ts node x-pack/legacy/plugins/siem/scripts/unoptimize_tsconfig ``` Testing and what this does: Run this: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Then run your start-test-all or at least your linter, typescript check, and jest tests to make sure they all operate as expected. Restart your IDE and ensure everything works as expected. Run `git status` and ensure it looks like no new files want to be checked in. Open up your: ```ts kibana/x-pack/tsconfig.json ``` And notice it is now changed when optimization has run to use a smaller set of includes. Open up your: ```ts kibana/tsconfig.json ``` And notice it is now changed when optimization is run to use a smaller set of includes.
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Mar 25, 2020
## Summary This adds an optimization script very copied and slightly modified from: * elastic#49868 Usage: Run this to do an dev tsconfig optimization: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Run this to undo the optimization: ```ts node x-pack/legacy/plugins/siem/scripts/unoptimize_tsconfig ``` Testing and what this does: Run this: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Then run your start-test-all or at least your linter, typescript check, and jest tests to make sure they all operate as expected. Restart your IDE and ensure everything works as expected. Run `git status` and ensure it looks like no new files want to be checked in. Open up your: ```ts kibana/x-pack/tsconfig.json ``` And notice it is now changed when optimization has run to use a smaller set of includes. Open up your: ```ts kibana/tsconfig.json ``` And notice it is now changed when optimization is run to use a smaller set of includes.
FrankHassanabad
added a commit
that referenced
this pull request
Mar 26, 2020
) ## Summary This adds an optimization script very copied and slightly modified from: * #49868 Usage: Run this to do an dev tsconfig optimization: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Run this to undo the optimization: ```ts node x-pack/legacy/plugins/siem/scripts/unoptimize_tsconfig ``` Testing and what this does: Run this: ```ts node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig ``` Then run your start-test-all or at least your linter, typescript check, and jest tests to make sure they all operate as expected. Restart your IDE and ensure everything works as expected. Run `git status` and ensure it looks like no new files want to be checked in. Open up your: ```ts kibana/x-pack/tsconfig.json ``` And notice it is now changed when optimization has run to use a smaller set of includes. Open up your: ```ts kibana/tsconfig.json ``` And notice it is now changed when optimization is run to use a smaller set of includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's the charm. Previous attempts:
This attempt adds two scripts in
apm/scripts, that either create a tsconfig.json optimized for APM, or undo the changes in the optimization. Here's what the optimization process is like:tsconfig.jsonfile inx-pack/legacy/plugins/apmtsconfig.jsons toapm.tsconfig.jsonso these projecst are not bootstrapped by VS Code when a file from those projects is encountered.--skip-worktreefor thosetsconfig.jsons to prevent any changes to these files (including deleting them) to show up in the git staging area.