Feature/5.0 #6047
Merged
Feature/5.0 #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panda01
commented
Jan 29, 2016
panda01
commented
- Moves the App level navigation to the left hand side.
- Changes the kibana logo.
- Exposes the line numbers for less files.
- Adds dummy links as placeholders for users and settings.
| @@ -19,7 +19,7 @@ var chrome = require('ui/chrome'); | |||
| var routes = require('ui/routes'); | |||
| var modules = require('ui/modules'); | |||
|
|
|||
| var kibanaLogoUrl = require('ui/images/kibana.svg'); | |||
| var kibanaLogoUrl = require('ui/images/kibana.gif'); | |||
There was a problem hiding this comment.
Just a temporary change to use gif instead of svg?
minor copy improvements (typos)
…ebar function as expected with overlap
…red, added placedholders for users and settings, fixed the sizing on the logo
| @@ -101,7 +102,7 @@ class BaseOptimizer { | |||
| test: /\.less$/, | |||
| loader: ExtractTextPlugin.extract( | |||
| 'style', | |||
| `css${mapQ}!autoprefixer${mapQ ? mapQ + '&' : '?'}{ "browsers": ["last 2 versions","> 5%"] }!less${mapQ}` | |||
| `css${mapQ}!autoprefixer${mapQPre}{ "browsers": ["last 2 versions","> 5%"] }!less${mapQPre}dumpLineNumbers=comments` | |||
There was a problem hiding this comment.
is this something we can do in a separate PR? to master maybe? it's going to increase filesizes a bit, probably something we don't want in production/
|
Status page doesn't have the logo: edit: on second thought, is the status page supposed to have any navigation? |
|
Hovering over the navbar shows a scrollbar causing the bottom content to shift up. |
|
|
||
| > * { | ||
| flex-shrink: 0; | ||
| } | ||
| } | ||
| .real-flex-parent(@display: flex, @flow: column nowrap) { |
There was a problem hiding this comment.
does it make sense to have display a param given the function name? maybe we can name this something like flex-parent-flow?
|
|
||
| body { overflow: hidden; } |
There was a problem hiding this comment.
this is preventing scrolling on a few pages, discover for example
…the user and settings icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.