-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugins to add config sections to the chrome ui #6136
Comments
I agree, with the design update the navbar is changing in such a way that we don't really have a chrome at the top of the page. I don't know if the You might be better off trying to write a sledgehammer for now. |
@spalger, where are the "config" sections going in the new design? And I've seen some talk about the sledgehammer, do you have any more info? |
The It's really up to @jbudz and @panda01 I think, they're working on the implementation. As for the sledgehammer deal, checkout the updated description I popped into the pr #6122 |
Thanks for the clarification. |
@spalger, here's my idea on how to implement this: Create a new registry. I don't think I'll convert the appSwitcher since that looks to be going away in the new design. Also, I'm combining both the navbar control and config control under the same object because I need to be able to share the ConfigTemplate between the two. |
Yeah, that's the design I would like to implement as well, once the app switcher is converted and we figure out what we're going to do with the taskbar in the new layout. |
Are you ok with me working on this or should I hold off until you've figured out the new layout? |
@spalger, I created a pull request for this. |
@spalger Do you think this issue can/should be closed? Is it still applicable? |
Yeah. This is possible using the |
With the addition of the chromeNavControlsRegistry, plugins are able to add items to the nav bar at the top. It would be nice if the plugins could also register config dropdowns. I think it should be tied with the chromeNavControls so that you could register both a navbar and a config together.
The text was updated successfully, but these errors were encountered: